Skip to content

fix: preview mode for odb/fallback pages #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 2, 2021
Merged

fix: preview mode for odb/fallback pages #564

merged 7 commits into from
Aug 2, 2021

Conversation

lindsaylevine
Copy link

Fixes #440

@lindsaylevine lindsaylevine added the type: bug code to address defects in shipped code label Jul 29, 2021
ascorbic
ascorbic approved these changes Jul 29, 2021
View reviewed changes
Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. How annoying that this is needed!

@ascorbic ascorbic enabled auto-merge (squash) July 29, 2021 09:13
@ascorbic ascorbic disabled auto-merge July 29, 2021 09:13
@ascorbic ascorbic merged commit 0732219 into main Aug 2, 2021
@ascorbic ascorbic deleted the odb-preview-mode branch August 2, 2021 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascorbic ascorbic ascorbic approved these changes

@lukeocodes lukeocodes Awaiting requested review from lukeocodes

Assignees
No one assigned
Labels
type: bug code to address defects in shipped code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Preview mode with ODB-supported pages
2 participants
@lindsaylevine @ascorbic