Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade NoN to 2.8.2, explain CLI usage workflow in README, add jimp #83

Merged
merged 1 commit into from
Jan 16, 2021

Conversation

lindsaylevine
Copy link

@lindsaylevine lindsaylevine commented Jan 14, 2021

Fixes #74
Fixes #85
Fixes #84

next-on-netlify 2.8.1 now has file tracking per netlify/next-on-netlify#134. this is definitely a bandaid but a decent one to get people using the CLI who want to use it. i updated the README to recommend a workflow for managing the git file tracking until we can come up with a better solution.

@lindsaylevine lindsaylevine added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Jan 14, 2021
@lindsaylevine
Copy link
Author

cc @FinnWoelm

@lindsaylevine
Copy link
Author

lindsaylevine commented Jan 14, 2021

hm. tests failing here in next-on-netlify with this error TypeError: The "path" argument must be of type string:

const cacheDir = findCacheDir({ name: "next-on-netlify", create: true });
const trackingFilePath = join(cacheDir, ".nonfiletracking");

tests pass when i delete the join line. assuming findCacheDir create: true will always output the "created" cacheDir, i'm not sure why it's coming back as undefined. i suppose that assumption is wrong 🤪 .

@lindsaylevine
Copy link
Author

i'm guessing this is because of our strange node_modules/test setup in this repo? wonder if there's a workaround without having to update NoN but you probably know best @ehmicky

@ehmicky
Copy link

ehmicky commented Jan 15, 2021

It looks like find-cache-dir can return undefined if either:

  • No package.json can be found in cwd or any parent directory
  • There is no node_modules directory next to package.json

https://github.com/avajs/find-cache-dir/blob/05a0b0833752b9cd2fe59973688e7f4de2c210a7/index.js#L57

@lindsaylevine lindsaylevine changed the title upgrade NoN to 2.8.1 and explain CLI usage workflow in README upgrade NoN to 2.8.2, explain CLI usage workflow in README, add jimp Jan 16, 2021
@lindsaylevine lindsaylevine merged commit 05d342a into main Jan 16, 2021
@lindsaylevine lindsaylevine deleted the ll/upgrade-non-2.8.1 branch January 16, 2021 14:42
lindsaylevine added a commit that referenced this pull request Jan 16, 2021
- upgrade NoN to 2.8.2; explain CLI usage workflow in README; add jimp ([#83](#83))
- update next.config.js target error message to be more clear ([78a0986](78a0986))
serhalp pushed a commit that referenced this pull request Apr 5, 2024
* chore: trigger e2e on branch push

* chore: add swc to workspace root

* chore: install playwright for e2e

* chore: show passed test results

* chore: increase e2e timeout

* chore: add missing then in bash

* chore: increase matrix jobs

* chore: add test result totals to e2e summary

* chore: fix group split in e2e

* chore: fix failed test details in e2e

* chore: betterer grammar

* chore: increase e2e timeout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
2 participants