optimize: shdict: switched exptime argument type to 'long' to avoid potential overflows. #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaultcha
force-pushed
the
refactor/ttl-use-long-type
branch
from
6a04b13 to
d800b14
Compare
|
@agentzh The Travis builds were really janky yesterday it seems, several PRs I sent didn't pass the CI for unrelated reasons. Hoping you get a chance to restart them :) |
|
@spacewander has fixed this bug already: #171 it was not merged now. |
|
@membphis did you mean to link to another PR or am I overlooking something? |
|
@thibaultcha you can ignore the error in travis build. it's fixed at another PR #171. |
|
Oh, sorry I thought you were talking about the PR itself! Ok! :D |
|
@membphis thanks for the note! |
…otential overflows.
thibaultcha
force-pushed
the
refactor/ttl-use-long-type
branch
from
d800b14 to
7633a99
Compare
|
@thibaultcha Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sister PR of openresty/lua-nginx-module#1229