Skip to content

Conversation

@ruven
Copy link

@ruven ruven commented May 5, 2025

This adds tilesource links, example demos and documentation related to openseadragon/openseadragon#2719

Note that the OSD website javascript files had to be updated in order for the demos to work

ruven added 2 commits May 5, 2025 11:44
…agon#2719

Added tilesource page with examples + links from index.html and creating zooming images page.
Note that IIP tilesource page tentatively states that version OSD 5.0.2 or later is required - I don't know how you want to handle versioning.
Copy link
Member

@iangilman iangilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. This is beautiful! Thank you for providing such good detailed information.

We won't merge this until version 6.0.0 of OSD is released. At that time, we'll bring in the latest OSD library, which will replace the built-openseadragon included in this PR.

Thank you for adding IIPImage to the other categories in the "creating" page... I didn't realize it supported so many!

The organization on the "creating" page is a little weird, but I think we've mostly stuck with alphabetical. Would you mind moving the IIPImage entries around so they fit alphabetically into the various categories? Also, I think it would be good to move IIP itself so it is listed alphabetically.

The IIP page itself looks fantastic! Lots of good info.

One thing, I'm seeing in the console this error:

image

I assume that's not just because I'm running locally? Can it be fixed on the image server? If not, maybe add drawer: 'canvas' to suppress the error? You don't need to include that in the visible code for the user, just the code running on the page.

Thank you for putting all of this together!

@ruven
Copy link
Author

ruven commented May 7, 2025

The console error is because the images are coming from an external source. It also happens on the IIIF tilesource page if you run it locally. It should be fine on the website, but I put in your 'canvas' suggestion just to be sure.

By the way, the "Supported Tile Sources" list on the index page is not in alphabetical order. Maybe I should rename IIPImage to AAAAIIPImage like in the good old days of web search optimization 😉

Copy link
Member

@iangilman iangilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Thank you for resorting them.

By the way, the "Supported Tile Sources" list on the index page is not in alphabetical order. Maybe I should rename IIPImage to AAAAIIPImage like in the good old days of web search optimization

Yes, we need more duplicated letters in our acronyms!

I spent some times looking at that list (on the homepage) thinking about how best to organize it. It may be that alphabetical is the way to go, though I kind of feel like some of them (legacy, simple, and custom) kind of feel like a different category and maybe shouldn't just be sorted in the middle of the list. Of course when the list was small it didn't really matter, but it keeps getting bigger! I'm certainly open to ideas for how to better organize it!

…de with the caption CSS moved to global style.css.
@ruven
Copy link
Author

ruven commented May 11, 2025

I spent some times looking at that list (on the homepage) thinking about how best to organize it. It may be that alphabetical is the way to go, though I kind of feel like some of them (legacy, simple, and custom) kind of feel like a different category and maybe shouldn't just be sorted in the middle of the list.

Yes, I would agree. How about separating the legacy, simple and custom from the rest and placing them at the beginning in a separate list. Then having a h4 header called something like Tile Source APIs followed by the alphabetical list of DZI, IIIF, etc?

@iangilman
Copy link
Member

Sounds good! Would you like to do that?

@ruven
Copy link
Author

ruven commented May 14, 2025

Sounds good! Would you like to do that?

OK done

@iangilman
Copy link
Member

Awesome. Thank you for going above and beyond to help clean things up!

I think we're good here. We'll just leave this PR as is, to merge when we release OSD 6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants