Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GitHub Request] Add @Vikasht34 as the maintainer for the k-NN repo #281

Closed
navneet1v opened this issue Feb 2, 2025 · 3 comments
Closed
Assignees

Comments

@navneet1v
Copy link

What is the type of request?

User Permission

Details of the request

We would like to add @Vikasht34 to MAINTAINERS.md and .github/CODEOWNERS of opensearch plugin repos [k-NN] so that he can approve PRs and merge code into the main branch.

Additional information to support your request

We have received upvotes (including myself) from existing maintainers of opensearch k-nn to add @Vikasht34 as the maintainers of this repo.

Vikash has been working on different features in k-NN plugin for last 8-9 months. He has developed the quantization framework in the k-NN plugin and currently working on improving the Quantization techniques to further improve the disk-based vector search. He has also been working as the release owner for 3.0 release.
Below are some of his PRs
opensearch-project/k-NN#2183
opensearch-project/k-NN#2149
opensearch-project/k-NN#2087
opensearch-project/k-NN#2010
opensearch-project/k-NN#1967
Along with the features he has been an active reviewer of different pull requests. Some of them are added below.
opensearch-project/k-NN#2376
opensearch-project/k-NN#1960
opensearch-project/k-NN#1969
opensearch-project/k-NN#1984
opensearch-project/k-NN#1997

More PRs can be found here: https://github.com/opensearch-project/k-NN/pulls?q=is%3Apr+reviewed-by%3AVikasht34

The nomination process is following: https://github.com/opensearch-project/.github/blob/main/RESPONSIBILITIES.md#nomination

Tagging maintainers who have already upvoted: @navneet1v @naveentatikonda @ryanbogan @shatejas @jmazanec15

When does this request need to be completed?

This is not an urgent request. 2-3 business days is fine.

Notes

Track the progress of your request here: https://github.com/orgs/opensearch-project/projects/208/views/33.
Member of @opensearch-project/admin will take a look at the request soon.
Thanks!

@peterzhuamazon
Copy link
Member

@peterzhuamazon
Copy link
Member

Reviewed email chain and confirmed the votes.

@peterzhuamazon
Copy link
Member

Added @Vikasht34 as maintainer and updated/approve the PR.

Thanks.

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Engineering Effectiveness Board Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants