Adding Vikasht34 as maintainer for k-NN repo #2482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
created the GH issue for the request: opensearch-project/.github#281 |
|
@naveentatikonda @ryanbogan @shatejas @jmazanec15 can you please approve this PR |
|
Following the steps mentioned here: #2364 (comment) |
naveentatikonda
previously approved these changes
Feb 2, 2025
shatejas
previously approved these changes
Feb 3, 2025
jmazanec15
reviewed
Feb 3, 2025
ryanbogan
previously approved these changes
Feb 3, 2025
Signed-off-by: Navneet Verma <[email protected]>
navneet1v
dismissed stale reviews from ryanbogan, shatejas, and naveentatikonda
via
9fceda0
navneet1v
force-pushed
the
addMaintainer
branch
from
6e366e6 to
9fceda0
Compare
MAINTAINERS.md
Outdated
| @@ -17,5 +17,6 @@ This document contains a list of maintainers in this repo. See [opensearch-proje | |||
| | Tejas Shah | [shatejas](https://github.com/shatejas) | Amazon | | |||
| | Vamshi Vijay Nakkirtha | [vamshin](https://github.com/vamshin) | Amazon | | |||
| | Vijayan Balasubramanian | [VijayanB](https://github.com/VijayanB) | Amazon | | |||
| | Vikasht34 | [Vikasht34](https://github.com/Vikasht34) | Amazon | | |||
There was a problem hiding this comment.
nit: Can we add his full name like others instead of github id ?
There was a problem hiding this comment.
This is the name on the github. so I went with that.
Signed-off-by: Peter Zhu <[email protected]>
peterzhuamazon
approved these changes
Feb 3, 2025
navneet1v
requested review from
heemin32,
VijayanB,
vamshin,
junqiu-lei,
martin-gaievski,
luyuncheng and
0ctopus13prime
as code owners
naveentatikonda
approved these changes
Feb 3, 2025
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2482-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fa70fc845711b9b6e222f63d9ddc137f1ead10af
# Push it to GitHub
git push --set-upstream origin backport/backport-2482-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
navneet1v
added a commit
that referenced
this pull request
Feb 3, 2025
* Adding Vikasht34 as the maintainer in k-NN repo Signed-off-by: Navneet Verma <[email protected]> * Update MAINTAINERS.md Signed-off-by: Peter Zhu <[email protected]> --------- Signed-off-by: Navneet Verma <[email protected]> Signed-off-by: Peter Zhu <[email protected]> Co-authored-by: Peter Zhu <[email protected]>
navneet1v
added a commit
that referenced
this pull request
Feb 3, 2025
* Adding Vikasht34 as the maintainer in k-NN repo Signed-off-by: Navneet Verma <[email protected]> * Update MAINTAINERS.md Signed-off-by: Peter Zhu <[email protected]> --------- Signed-off-by: Navneet Verma <[email protected]> Signed-off-by: Peter Zhu <[email protected]> Co-authored-by: Peter Zhu <[email protected]>
5 tasks
navneet1v
added a commit
that referenced
this pull request
Feb 3, 2025
* Adding Vikasht34 as the maintainer in k-NN repo * Update MAINTAINERS.md --------- Signed-off-by: Navneet Verma <[email protected]> Signed-off-by: Peter Zhu <[email protected]> Co-authored-by: Peter Zhu <[email protected]>
Vikasht34
pushed a commit
to Vikasht34/k-NN
that referenced
this pull request
Feb 12, 2025
* Adding Vikasht34 as the maintainer in k-NN repo Signed-off-by: Navneet Verma <[email protected]> * Update MAINTAINERS.md Signed-off-by: Peter Zhu <[email protected]> --------- Signed-off-by: Navneet Verma <[email protected]> Signed-off-by: Peter Zhu <[email protected]> Co-authored-by: Peter Zhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding Vikasht34 as the maintainer in k-NN repo
Related Issues
NA
Check List
New functionality includes testing.New functionality has been documented.API changes companion pull request created.--signoff.Public documentation issue/PR created.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.