Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover]: Make colour of discover histogram match theme #9405

Merged
merged 2 commits into from
Feb 18, 2025
Merged

[Discover]: Make colour of discover histogram match theme #9405

merged 2 commits into from
Feb 18, 2025

Conversation

Maosaic
Copy link
Contributor

@Maosaic Maosaic commented Feb 17, 2025

Description

Make colour of discover histogram match theme

Issues Resolved

Screenshot

Before
2172

After
2171

Testing the changes

Changelog

  • chore: Make colour of discover histogram match theme

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@codecov Codecov
Copy link

codecov bot commented Feb 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 61.71%. Comparing base (8284b2d) to head (45bfca1).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...plication/components/chart/histogram/histogram.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9405      +/-   ##
==========================================
- Coverage   61.71%   61.71%   -0.01%     
==========================================
  Files        3817     3817              
  Lines       91860    91862       +2     
  Branches    14551    14552       +1     
==========================================
  Hits        56695    56695              
- Misses      31508    31510       +2     
  Partials     3657     3657
Flag Coverage Δ
Linux_1 29.00% <0.00%> (-0.01%) ⬇️
Linux_2 56.46% <ø> (ø)
Linux_3 39.19% <0.00%> (-0.01%) ⬇️
Linux_4 28.90% <0.00%> (-0.01%) ⬇️
Windows_1 29.01% <0.00%> (-0.01%) ⬇️
Windows_2 56.41% <ø> (ø)
Windows_3 39.20% <0.00%> (-0.01%) ⬇️
Windows_4 28.90% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sejli sejli added the discover for discover reinvent label Feb 18, 2025
@kavilla kavilla merged commit 22d8063 into opensearch-project:main Feb 18, 2025
75 of 77 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 18, 2025
@github-actions @opensearch-changeset-bot
[Discover]: Make colour of discover histogram match theme (#9405)
934814f 
* [Discover]: Make color of discover histogram match theme

Signed-off-by: Joey Liu <[email protected]>

* Changeset file for PR #9405 created/updated

---------

Signed-off-by: Joey Liu <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 22d8063)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Feb 18, 2025
Merged
sumukhswamy pushed a commit to sumukhswamy/OpenSearch-Dashboards that referenced this pull request Feb 18, 2025
@Maosaic @opensearch-changeset-bot @sumukhswamy
[Discover]: Make colour of discover histogram match theme (opensearch…
08a7217 
…-project#9405)

* [Discover]: Make color of discover histogram match theme

Signed-off-by: Joey Liu <[email protected]>

* Changeset file for PR opensearch-project#9405 created/updated

---------

Signed-off-by: Joey Liu <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
kavilla added a commit that referenced this pull request Feb 19, 2025
@opensearch-trigger-bot @github-actions
@opensearch-changeset-bot @kavilla
[Discover]: Make colour of discover histogram match theme (#9405) (#9414
be48136 
)

* [Discover]: Make color of discover histogram match theme



* Changeset file for PR #9405 created/updated

---------



(cherry picked from commit 22d8063)

Signed-off-by: Joey Liu <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Kawika Avilla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angle943 angle943 angle943 approved these changes

@kavilla kavilla kavilla approved these changes

@sejli sejli sejli approved these changes

@d-buckner d-buckner d-buckner approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
backport 2.x discover for discover reinvent repeat-contributor v2.20.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Maosaic @angle943 @kavilla @sejli @d-buckner