Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] use before/after and consolidate #9439

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

angle943
Copy link
Collaborator

Description

  • use before and after where applicable instead of beforeEach/afterEach in order to speed up the tests
  • There were a lot of duplicated code within those blocks, so create cy.osd.setupWorkspaceAndDataSourceWithIndices and cy.osd.cleanupWorkspaceAndDataSourceAndIndices

Changelog

  • test: use before/after to speed up test

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

…te some duplicated code within those blocks

Signed-off-by: Justin Kim <[email protected]>
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.74%. Comparing base (796e481) to head (abdef79).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9439   +/-   ##
=======================================
  Coverage   61.74%   61.74%           
=======================================
  Files        3816     3816           
  Lines       91890    91890           
  Branches    14564    14564           
=======================================
+ Hits        56738    56740    +2     
+ Misses      31494    31493    -1     
+ Partials     3658     3657    -1     
Flag Coverage Δ
Linux_1 28.98% <ø> (ø)
Linux_2 56.41% <ø> (ø)
Linux_3 39.27% <ø> (+<0.01%) ⬆️
Linux_4 28.87% <ø> (ø)
Windows_1 29.00% <ø> (ø)
Windows_2 56.37% <ø> (ø)
Windows_3 39.27% <ø> (ø)
Windows_4 28.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Justin Kim <[email protected]>
@angle943 angle943 marked this pull request as ready for review February 26, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant