-
Notifications
You must be signed in to change notification settings - Fork 966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TEST] use before/after and consolidate #9439
Open
angle943
wants to merge
12
commits into
opensearch-project:main
Choose a base branch
from
angle943:beforeEach-before
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+629
−990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te some duplicated code within those blocks Signed-off-by: Justin Kim <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9439 +/- ##
=======================================
Coverage 61.74% 61.74%
=======================================
Files 3816 3816
Lines 91890 91890
Branches 14564 14564
=======================================
+ Hits 56738 56740 +2
+ Misses 31494 31493 -1
+ Partials 3658 3657 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
before
andafter
where applicable instead ofbeforeEach/afterEach
in order to speed up the testscy.osd.setupWorkspaceAndDataSourceWithIndices
andcy.osd.cleanupWorkspaceAndDataSourceAndIndices
Changelog
Check List
yarn test:jest
yarn test:jest_integration