Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Removed log entry regarding destination migration #1494

Merged
merged 1 commit into from
Mar 22, 2024
Merged

[Backport 2.x] Removed log entry regarding destination migration #1494

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...tlin/org/opensearch/alerting/util/destinationmigration/DestinationMigrationCoordinator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ class DestinationMigrationCoordinator(
}

override fun clusterChanged(event: ClusterChangedEvent) {
logger.info("Detected cluster change event for destination migration")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be swapped to debug instead of removed?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can, but it's redundant. We already have an if-else clause for each condition, which captures the required information in the log lines.

if (DestinationMigrationUtilService.finishFlag) {
logger.info("Reset destination migration process.")
scheduledMigration?.cancel()
Expand All @@ -63,6 +62,7 @@ class DestinationMigrationCoordinator(
runningLock = false
}
} else if (!event.localNodeClusterManager()) {
logger.info("Cancelling the migration process.")
scheduledMigration?.cancel()
}
}
Expand Down
Loading