Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release 3.0] Added alpha1 qualifier. Updated shadow plugin reference. #1786

Merged
merged 16 commits into from
Feb 27, 2025

Conversation

AWSHurneyt
Copy link
Collaborator

@AWSHurneyt AWSHurneyt commented Jan 29, 2025

Description

  1. Added alpha1 qualifier.
  2. Updated shadow plugin reference.
  3. Fixed imports.

To align with common utils - opensearch-project/common-utils#775

Related Issues

opensearch-project/opensearch-build#5267
opensearch-project/opensearch-build#3747

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@aggarwalShivani
Copy link

Looking forward to this getting merged soon :)

index-management depends on alerting plugin, and the alpha-1 version update (issue #1373) cannot be done in ism until it is completed in alerting plugin.

@peterzhuamazon
Copy link
Member

Hi @AWSHurneyt are we able to fix and merge this PR to unblock others?

Thanks!

nishtham-amazon and others added 7 commits February 25, 2025 17:51
…low is re-enabled (opensearch-project#1778)

* Force create last run context in monitor worflow metadata when workflow is re-enabled

Signed-off-by: Nishtha Mehrotra <[email protected]>

* Force creation of re-enabled doc level monitors

Signed-off-by: Nishtha Mehrotra <[email protected]>

* Updated IT

Signed-off-by: Nishtha Mehrotra <[email protected]>

---------

Signed-off-by: Nishtha Mehrotra <[email protected]>
Co-authored-by: Nishtha Mehrotra <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
@AWSHurneyt AWSHurneyt marked this pull request as ready for review February 27, 2025 00:28
@AWSHurneyt
Copy link
Collaborator Author

The failing tests are either security-enabled tests (as mentioned in opensearch-project/notifications#1002 (comment), the security-enabled test workflow needs to be refactored away from using docker), or backwards compatibility tests (example).

Will take a follow-up item to refactor those workflows, and get this bump PR merged to unblock bumping security analytics.

@peterzhuamazon
Copy link
Member

Thanks @AWSHurneyt , I approve this PR on the base that code assemble is passing.
So we can unblock other plugins that depends on alerting.

Thanks.

@AWSHurneyt AWSHurneyt merged commit d873d91 into opensearch-project:main Feb 27, 2025
8 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants