adding prompt when datasource is not compatible #608
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: saimedhi <[email protected]>
saimedhi
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz,
jackiehanyang and
minalsha
as code owners
|
ohltyler
requested changes
Feb 8, 2025
There was a problem hiding this comment.
Suggest 2 things:
- Can we have the messaging cover the entire page, instead of nested in the
New workflowtab? That prevents any other changes of side effects from users clicking on other things, such as import - The wording "incompatible data source" does not make sense, since there is no data source selected. Please confirm with UX on the wording.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This case is applicable to when datasource is enabled.
And when the current using datasources are not compatible with opensearch flow. Then datasourceId will not be present in url.
In the above mentioned case, displaying prompt message for users saying datasources are incompatible and add more compatible datasources.
Issues Resolved
#537 (comment)
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.