Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Notebook Observability Visualization loading #1312

Merged
merged 4 commits into from
Dec 20, 2023

Conversation

pjfitzgibbons
Copy link
Contributor

Description

Observability Visualizations fail to load on Notebook

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (fd55726) 57.44% compared to head (908a961) 57.44%.

Files Patch % Lines
public/components/custom_panels/helpers/utils.tsx 0.00% 7 Missing ⚠️
...ks/components/paragraph_components/para_output.tsx 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #1312      +/-   ##
==========================================
- Coverage   57.44%   57.44%   -0.01%     
==========================================
  Files         330      330              
  Lines       12094    12099       +5     
  Branches     2793     2791       -2     
==========================================
+ Hits         6948     6950       +2     
- Misses       5100     5103       +3     
  Partials       46       46              
Flag Coverage Δ
dashboards-observability 57.44% <52.63%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ps48
Copy link
Member

ps48 commented Dec 19, 2023

I still see some issues when adding a PPL visualization to notebook, the paragraph goes blank and the loader keeps on going infinitely. It gets fixed when I refresh the page.
Screenshot 2023-12-19 at 2 08 23 PM

@pjfitzgibbons
Copy link
Contributor Author

... looking more.

@ps48
Copy link
Member

ps48 commented Dec 19, 2023

Also, seeing another issue I'm seeing is time filter isn't working as expected for the PPL visualizations.

@pjfitzgibbons pjfitzgibbons force-pushed the bugfix/notebooks-observability-visualizations-load branch from b8c949e to bfd8c93 Compare December 20, 2023 00:30
@pjfitzgibbons pjfitzgibbons merged commit 566981f into 2.x Dec 20, 2023
11 of 29 checks passed
@pjfitzgibbons pjfitzgibbons deleted the bugfix/notebooks-observability-visualizations-load branch December 20, 2023 18:35
@opensearch-trigger-bot
Copy link
Contributor

The backport to main failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-main main
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-main
# Create a new branch
git switch --create backport/backport-1312-to-main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 566981fa87cb921b82e125eb01e22d88f249a21c
# Push it to GitHub
git push --set-upstream origin backport/backport-1312-to-main
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-main

Then, create a pull request where the base branch is main and the compare/head branch is backport/backport-1312-to-main.

@ps48 ps48 mentioned this pull request Dec 21, 2023
6 tasks
mengweieric pushed a commit to mengweieric/dashboards-observability that referenced this pull request Dec 22, 2023
…ect#1312)

* Fix for Notebook Observability Visualization loading

---------

Signed-off-by: Peter Fitzgibbons <[email protected]>
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
…ect#1312)

* Fix for Notebook Observability Visualization loading

---------

Signed-off-by: Peter Fitzgibbons <[email protected]>
(cherry picked from commit 566981f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants