Pull integrations integration test fixes to 2.x #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swiddis
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsimanohar,
penghuo,
seankao-az and
anirudha
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1331 +/- ##
==========================================
- Coverage 51.61% 51.59% -0.03%
==========================================
Files 305 305
Lines 10653 10659 +6
Branches 2790 2793 +3
==========================================
Hits 5499 5499
- Misses 5108 5114 +6
Partials 46 46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
RyanL1997
approved these changes
Jan 2, 2024
There was a problem hiding this comment.
Hi @Swiddis, thanks for taking this on. This is LGTM, btw since @mengweieric enabled the lint, I think we should also fix some of the lint errors for the test files.
6 tasks
ps48
reviewed
Jan 3, 2024
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Swiddis
force-pushed
the
backport-cypress-fixes-2x
branch
from
9b23d6e to
1f8a5db
Compare
ps48
approved these changes
Jan 3, 2024
mengweieric
approved these changes
Jan 4, 2024
RyanL1997
pushed a commit
to RyanL1997/dashboards-observability
that referenced
this pull request
Apr 18, 2024
…rch-project#1332) Signed-off-by: Peter Nied <[email protected]> (cherry picked from commit a0394415cd0f3cefad39c4cac9f7c9d6c23a62d1) Co-authored-by: Peter Nied <[email protected]>
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
) * Pull integration test fixes Signed-off-by: Simeon Widdis <[email protected]> * Fix lints for integrations.spec.js Signed-off-by: Simeon Widdis <[email protected]> * Fix lint errors for setup_integration.tsx Signed-off-by: Simeon Widdis <[email protected]> * Revert changes to .eslintrc.js Signed-off-by: Simeon Widdis <[email protected]> --------- Signed-off-by: Simeon Widdis <[email protected]> (cherry picked from commit 8edaf13)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looks like fixes were lost in backporting, this PR copies them over. This fixes the integration tests action for integrations on the 2.x branch.
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.