Add actual integration queries to table #1544

Swiddis · 2024-03-15T23:25:23Z

Description

Adds the ability to dynamically load integrations into the installed integrations table, and reactivates the tab. Also adds some terminal spacing to the S3 setup page since it was getting clipped by the bottom bar.

TODO: Cypress tests

Empty Table:

When an empty test integration is added that matches the data source:

Issues Resolved

N/A

Check List

New functionality includes testing.
- All tests pass, including unit test, integration test and doctest
New functionality has been documented.
- New functionality has javadoc added
- New functionality has user manual doc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Simeon Widdis <[email protected]>

…d-integ-table

Signed-off-by: Simeon Widdis <[email protected]>

…talled-integs

Signed-off-by: Simeon Widdis <[email protected]>

Swiddis · 2024-03-15T23:26:36Z

Depends on #1530

…d-integ-table

…/Swiddis/dashboards-observability into feature/ds-installed-integ-table

…installed-integs

ps48 · 2024-03-15T23:34:56Z

server/adaptors/integrations/types.ts

@@ -124,6 +124,7 @@ interface AssetReference {
  assetId: string;
  isDefaultAsset: boolean;
  description: string;
+  status?: string;


Can the status be from an enum? I think these should be know types

I have a few things to fix with status so I made #1545, will work on it soon

ps48 · 2024-03-15T23:35:48Z

public/components/integrations/components/setup_integration.tsx

@@ -415,6 +415,9 @@ export function SetupIntegrationForm({
              </EuiFormRow>
            </>
          ) : null}
+          {/* Bottom bar will overlap content if there isn't some space at the end */}
+          <EuiSpacer />


nit. Euispacer has props for size="l"/"xl". May be use that.

Tried xxl but it was still too small, 2 default spacers did the trick

ps48 · 2024-03-15T23:37:18Z

public/components/integrations/components/added_integration.tsx

+      return <EuiHealth color="warning">Unknown</EuiHealth>;
+    case 'available':
+      return <EuiHealth color="success">Active</EuiHealth>;
+    case 'partially-available':
+      return <EuiHealth color="warning">Partially Available</EuiHealth>;
+    default:
+      return <EuiHealth color="danger">Critical</EuiHealth>;


not a blocker: Is there any documentation or comment where i can learn about how we determine the status?
As a user I would like to learn more about what statuses represent

We documented it in the design somewhere but I don't think we've added it to OSS docs, I'll see about finding a home for the info

codecov · 2024-03-15T23:40:53Z

Codecov Report

Attention: Patch coverage is 80.85106% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 57.96%. Comparing base (a07b3c1) to head (47727f9).

Files	Patch %	Lines
...ents/integrations/components/added_integration.tsx	60.00%	4 Missing ⚠️
...nage/integrations/installed_integrations_table.tsx	88.46%	3 Missing ⚠️
.../datasources/components/manage/data_connection.tsx	81.81%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1544      +/-   ##
==========================================
+ Coverage   57.74%   57.96%   +0.22%     
==========================================
  Files         362      363       +1     
  Lines       13301    13340      +39     
  Branches     3461     3468       +7     
==========================================
+ Hits         7680     7733      +53     
+ Misses       5562     5548      -14     
  Partials       59       59

Flag	Coverage Δ
dashboards-observability	`57.96% <80.85%> (+0.22%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This reverts commit ecb8fb3.

opensearch-trigger-bot · 2024-03-16T00:06:18Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.x
# Create a new branch
git switch --create backport/backport-1544-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ecb8fb394dc6f795b99cbb43b4b42055533456b6
# Push it to GitHub
git push --set-upstream origin backport/backport-1544-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1544-to-2.x.

* Stub integration type Signed-off-by: Simeon Widdis <[email protected]> * Fix links and statuses on integration table stub Signed-off-by: Simeon Widdis <[email protected]> * Add search bar and tests Signed-off-by: Simeon Widdis <[email protected]> * Add 'add integrations' button to installed integrations table Signed-off-by: Simeon Widdis <[email protected]> * Update added integration snapshot Signed-off-by: Simeon Widdis <[email protected]> * Add dynamic loading of integrations from store Signed-off-by: Simeon Widdis <[email protected]> * Add space after integration setup page Signed-off-by: Simeon Widdis <[email protected]> * Add empty integration state Signed-off-by: Simeon Widdis <[email protected]> --------- Signed-off-by: Simeon Widdis <[email protected]> (cherry picked from commit ecb8fb3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Stub integration type * Fix links and statuses on integration table stub * Add search bar and tests * Add 'add integrations' button to installed integrations table * Update added integration snapshot * Add dynamic loading of integrations from store * Add space after integration setup page * Add empty integration state --------- (cherry picked from commit ecb8fb3) Signed-off-by: Simeon Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…ensearch-project#1547) * Stub integration type * Fix links and statuses on integration table stub * Add search bar and tests * Add 'add integrations' button to installed integrations table * Update added integration snapshot * Add dynamic loading of integrations from store * Add space after integration setup page * Add empty integration state --------- (cherry picked from commit ecb8fb3) Signed-off-by: Simeon Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit ba00bb8)

Swiddis and others added 12 commits March 12, 2024 17:07

Stub integration type

e7568bf

Signed-off-by: Simeon Widdis <[email protected]>

Fix links and statuses on integration table stub

72c1fbb

Signed-off-by: Simeon Widdis <[email protected]>

Add search bar and tests

b546596

Signed-off-by: Simeon Widdis <[email protected]>

Add 'add integrations' button to installed integrations table

3f75ab4

Signed-off-by: Simeon Widdis <[email protected]>

Merge branch 'main' into feature/ds-installed-integ-table

3e5a854

Update added integration snapshot

3bdc454

Signed-off-by: Simeon Widdis <[email protected]>

Merge branch 'main' into feature/ds-installed-integ-table

b0d55e7

Merge remote-tracking branch 'upstream/main' into feature/ds-installe…

b3ea867

…d-integ-table

Add dynamic loading of integrations from store

7dd67d0

Signed-off-by: Simeon Widdis <[email protected]>

Merge remote-tracking branch 'upstream/main' into feature/ds-load-ins…

54cbfb1

…talled-integs

Add space after integration setup page

b4097f1

Signed-off-by: Simeon Widdis <[email protected]>

Add empty integration state

3cfcbd8

Signed-off-by: Simeon Widdis <[email protected]>

Swiddis requested review from ps48, kavithacm, derek-ho, joshuali925, dai-chen, YANG-DB, rupal-bq, mengweieric, vamsimanohar, penghuo, seankao-az, anirudha, paulstn and sumukhswamy as code owners March 15, 2024 23:25

Swiddis added 3 commits March 15, 2024 16:30

Merge remote-tracking branch 'upstream/main' into feature/ds-installe…

7e19d30

…d-integ-table

Merge branch 'feature/ds-installed-integ-table' of https://github.com…

e5180d5

…/Swiddis/dashboards-observability into feature/ds-installed-integ-table

Merge branch 'feature/ds-installed-integ-table' into feature/ds-load-…

47727f9

…installed-integs

Swiddis added enhancement New feature or request integrations Used to denote items related to the Integrations project labels Mar 15, 2024

ps48 reviewed Mar 15, 2024

View reviewed changes

ps48 approved these changes Mar 15, 2024

View reviewed changes

paulstn approved these changes Mar 15, 2024

View reviewed changes

Swiddis merged commit ecb8fb3 into opensearch-project:main Mar 15, 2024
17 of 24 checks passed

Swiddis deleted the feature/ds-load-installed-integs branch March 15, 2024 23:57

ps48 added a commit that referenced this pull request Mar 15, 2024

Revert "Add actual integration queries to table (#1544)"

09779de

This reverts commit ecb8fb3.

Swiddis mentioned this pull request Mar 16, 2024

Data Sources: Installed Integrations Table #1530

Closed

11 tasks

Swiddis added the backport 2.x label Mar 16, 2024

opensearch-trigger-bot bot added the backport-failed label Mar 16, 2024

Swiddis added backport 2.x and removed backport 2.x backport-failed labels Mar 16, 2024

opensearch-trigger-bot bot mentioned this pull request Mar 16, 2024

[Backport 2.x] Add "Installed Integrations" table to data sources view #1547

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add actual integration queries to table #1544

Add actual integration queries to table #1544

Swiddis commented Mar 15, 2024 •

edited

Loading

Swiddis commented Mar 15, 2024

ps48 Mar 15, 2024 •

edited

Loading

Swiddis Mar 16, 2024

ps48 Mar 15, 2024

Swiddis Mar 15, 2024

ps48 Mar 15, 2024

Swiddis Mar 15, 2024

codecov bot commented Mar 15, 2024 •

edited

Loading

opensearch-trigger-bot bot commented Mar 16, 2024

Add actual integration queries to table #1544

Add actual integration queries to table #1544

Conversation

Swiddis commented Mar 15, 2024 • edited Loading

Description

Issues Resolved

Check List

Swiddis commented Mar 15, 2024

ps48 Mar 15, 2024 • edited Loading

Choose a reason for hiding this comment

Swiddis Mar 16, 2024

Choose a reason for hiding this comment

ps48 Mar 15, 2024

Choose a reason for hiding this comment

Swiddis Mar 15, 2024

Choose a reason for hiding this comment

ps48 Mar 15, 2024

Choose a reason for hiding this comment

Swiddis Mar 15, 2024

Choose a reason for hiding this comment

codecov bot commented Mar 15, 2024 • edited Loading

Codecov Report

opensearch-trigger-bot bot commented Mar 16, 2024

Swiddis commented Mar 15, 2024 •

edited

Loading

ps48 Mar 15, 2024 •

edited

Loading

codecov bot commented Mar 15, 2024 •

edited

Loading