Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.13] Fixed small bugs in explorer #1580

Merged
merged 2 commits into from
Mar 20, 2024
Merged

[Backport 2.13] Fixed small bugs in explorer #1580

merged 2 commits into from
Mar 20, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 3cec4dc from #1559.

@github-actions
Fixed small bugs in explorer (#1559)
83e166d 
* disable ppl direct query autocomplete

Signed-off-by: Paul Sebastian <[email protected]>

* disable sorting for s3

Signed-off-by: Paul Sebastian <[email protected]>

* fix pagination for s3

Signed-off-by: Paul Sebastian <[email protected]>

* fix flyout to use actual row doc

Signed-off-by: Paul Sebastian <[email protected]>

* fix surrounding events

Signed-off-by: Paul Sebastian <[email protected]>

* allow for surrounding fields to work on s3

Signed-off-by: Paul Sebastian <[email protected]>

* fix lint complaint

Signed-off-by: Paul Sebastian <[email protected]>

* const instead of let

Signed-off-by: Paul Sebastian <[email protected]>

* changed naming for isDataSource bool

Signed-off-by: Paul Sebastian <[email protected]>

* update snapshot

Signed-off-by: Paul Sebastian <[email protected]>

---------

Signed-off-by: Paul Sebastian <[email protected]>
(cherry picked from commit 3cec4dc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@ps48 ps48 added the enhancement New feature or request label Mar 20, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 58.14%. Comparing base (cb78382) to head (83e166d).

Files Patch % Lines
...vent_analytics/explorer/events_views/data_grid.tsx 16.66% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             2.13    #1580      +/-   ##
==========================================
- Coverage   58.15%   58.14%   -0.02%     
==========================================
  Files         365      365              
  Lines       13549    13554       +5     
  Branches     3562     3564       +2     
==========================================
+ Hits         7880     7881       +1     
- Misses       5605     5609       +4     
  Partials       64       64
Flag Coverage Δ
dashboards-observability 58.14% <16.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ps48 ps48 merged commit 75e91db into 2.13 Mar 20, 2024
14 of 27 checks passed
@github-actions github-actions bot deleted the backport/backport-1559-to-2.13 branch March 20, 2024 02:20
RyanL1997 pushed a commit to RyanL1997/dashboards-observability that referenced this pull request Apr 18, 2024
@opensearch-trigger-bot @jochen-kressin @DarshitChanpura
The cookie splitter should be able to use cookie values that have bee…
6b86cd3 
…n set within the current request (opensearch-project#1580) (opensearch-project#1602)

Signed-off-by: Jochen Kressin <[email protected]>
Co-authored-by: Darshit Chanpura <[email protected]>
(cherry picked from commit d575e0001c406149a9df6e6c52c00057738e7536)

Co-authored-by: Jochen Kressin <[email protected]>
Co-authored-by: Darshit Chanpura <[email protected]>
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
@opensearch-trigger-bot
Fixed small bugs in explorer (opensearch-project#1559) (opensearch-pr…
a6b0dc4 
…oject#1580)

* disable ppl direct query autocomplete

* disable sorting for s3

* fix pagination for s3

* fix flyout to use actual row doc

* fix surrounding events

* allow for surrounding fields to work on s3

* fix lint complaint

* const instead of let

* changed naming for isDataSource bool

* update snapshot

---------

(cherry picked from commit 3cec4dc)

Signed-off-by: Paul Sebastian <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Shenoy Pratik <[email protected]>
(cherry picked from commit 75e91db)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ps48 ps48 ps48 approved these changes

@mengweieric mengweieric mengweieric approved these changes

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@rupal-bq rupal-bq Awaiting requested review from rupal-bq

@vamsimanohar vamsimanohar Awaiting requested review from vamsimanohar

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ps48 @mengweieric