-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating usePolling to cleanup after unmount #1598
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sean Li <[email protected]>
Signed-off-by: Sean Li <[email protected]>
This was referenced Mar 20, 2024
ps48
reviewed
Mar 20, 2024
...ents/datasources/components/manage/associated_objects/utils/associated_objects_tab_empty.tsx
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1598 +/- ##
==========================================
+ Coverage 57.76% 57.77% +0.01%
==========================================
Files 367 367
Lines 13808 13819 +11
Branches 3621 3627 +6
==========================================
+ Hits 7976 7984 +8
- Misses 5769 5772 +3
Partials 63 63
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…hecker in associated objects tab Signed-off-by: Sean Li <[email protected]>
ps48
approved these changes
Mar 20, 2024
Swiddis
approved these changes
Mar 20, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 20, 2024
* clear interval when component unmounts Signed-off-by: Sean Li <[email protected]> * updating empty state Signed-off-by: Sean Li <[email protected]> * adding back button on empty page, fixing empty accelerations length checker in associated objects tab Signed-off-by: Sean Li <[email protected]> --------- Signed-off-by: Sean Li <[email protected]> (cherry picked from commit a03bf43) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 20, 2024
* clear interval when component unmounts Signed-off-by: Sean Li <[email protected]> * updating empty state Signed-off-by: Sean Li <[email protected]> * adding back button on empty page, fixing empty accelerations length checker in associated objects tab Signed-off-by: Sean Li <[email protected]> --------- Signed-off-by: Sean Li <[email protected]> (cherry picked from commit a03bf43) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
pushed a commit
that referenced
this pull request
Mar 21, 2024
* clear interval when component unmounts * updating empty state * adding back button on empty page, fixing empty accelerations length checker in associated objects tab --------- (cherry picked from commit a03bf43) Signed-off-by: Sean Li <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
pushed a commit
that referenced
this pull request
Mar 21, 2024
* clear interval when component unmounts * updating empty state * adding back button on empty page, fixing empty accelerations length checker in associated objects tab --------- (cherry picked from commit a03bf43) Signed-off-by: Sean Li <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
RyanL1997
added a commit
to RyanL1997/dashboards-observability
that referenced
this pull request
Apr 18, 2024
…er (opensearch-project#1596) (opensearch-project#1598) Signed-off-by: Ryan Liang <[email protected]> (cherry picked from commit 1e7b4213551b6ecc4422fa9043c249521c1636bb) Co-authored-by: Ryan Liang <[email protected]>
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
opensearch-project#1601) * clear interval when component unmounts * updating empty state * adding back button on empty page, fixing empty accelerations length checker in associated objects tab --------- (cherry picked from commit a03bf43) Signed-off-by: Sean Li <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 1f78915)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
usePolling()
unmounts beforestopPolling()
is called, it causes thesetInterval
to become a zombie process in the background. Updated the hook such that we check if unmounted before exiting thestartPolling()
function and clear if true.Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.