Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.13] Updating usePolling to cleanup after unmount #1601

Merged
merged 1 commit into from
Mar 21, 2024

Updating usePolling to cleanup after unmount (#1598)

eac502c
Select commit
Loading
Failed to load commit list.
Merged

[Backport 2.13] Updating usePolling to cleanup after unmount #1601

Updating usePolling to cleanup after unmount (#1598)
eac502c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 20, 2024 in 1s

58.06% (+0.01%) compared to 1fe1926

View this Pull Request on Codecov

58.06% (+0.01%) compared to 1fe1926

Details

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 58.06%. Comparing base (1fe1926) to head (eac502c).

Files Patch % Lines
...nage/associated_objects/associated_objects_tab.tsx 80.00% 2 Missing ⚠️
public/components/hooks/use_polling.ts 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             2.13    #1601      +/-   ##
==========================================
+ Coverage   58.05%   58.06%   +0.01%     
==========================================
  Files         365      365              
  Lines       13621    13632      +11     
  Branches     3587     3593       +6     
==========================================
+ Hits         7908     7916       +8     
- Misses       5650     5653       +3     
  Partials       63       63              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.