Fixed bugs in explorer redirection #1609

paulstn · 2024-03-21T22:27:14Z

Description

allow for redirection in associated objects skipping indices
redirection in datasources table implemented
extended associated object type
fixed url redirection to stop causing crashes and unexpected issues, used mainly in the discover to explorer flow
extended the query text area character limit now to 2^14
change the direct query visualization error to open acc flyout in Q.W.
s3 no results page changes with sample queries and glue data cache support to populate a functioning query, shown in the following flows:|

s3 PPL empty page (no query run yet):

s3 SQL empty page (no query run yet):

s3 no results (post query run w/ no data returned):

Issues Resolved

[List any issues this PR will resolve]

Check List

New functionality includes testing.
- All tests pass, including unit test, integration test and doctest
New functionality has been documented.
- New functionality has javadoc added
- New functionality has user manual doc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Paul Sebastian <[email protected]>

codecov · 2024-03-21T23:12:47Z

Codecov Report

Attention: Patch coverage is 29.26829% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 57.66%. Comparing base (b4fd35e) to head (e3fa247).
Report is 5 commits behind head on main.

Files	Patch %	Lines
...components/event_analytics/explorer/no_results.tsx	31.25%	21 Missing and 1 partial ⚠️
...omponents/manage/manage_data_connections_table.tsx	0.00%	4 Missing ⚠️
...iated_objects/modules/associated_objects_table.tsx	0.00%	1 Missing ⚠️
...ted_objects/utils/associated_objects_tab_utils.tsx	50.00%	1 Missing ⚠️
.../datasources/components/manage/data_connection.tsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1609      +/-   ##
==========================================
- Coverage   57.75%   57.66%   -0.10%     
==========================================
  Files         367      367              
  Lines       13825    13880      +55     
  Branches     3627     3640      +13     
==========================================
+ Hits         7985     8004      +19     
- Misses       5777     5813      +36     
  Partials       63       63

Flag	Coverage Δ
dashboards-observability	`57.66% <29.26%> (-0.10%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Paul Sebastian <[email protected]>

common/types/data_connections.ts

Signed-off-by: Paul Sebastian <[email protected]>

Swiddis · 2024-03-25T22:46:42Z

common/constants/autocomplete.ts

@@ -6,6 +6,8 @@

 import { BaseItem } from '@algolia/autocomplete-core';

+export const textAreaMaxLength = 16384;


Just curious: where is this limit from? I don't see 2^14 often.

arbitrary amount where I looked at how long certain sql queries could be, i made a value judgement. we can always change it later, though

Swiddis · 2024-03-25T22:49:28Z

public/components/event_analytics/explorer/explorer.tsx

-      );
-      setTempQuery(queryToRun);
+      if (datasourceName && datasourceType) {
+        dispatch(


Another question out of curiosity: what's the benefit of dispatch over useEffect? I'm not sure what'd motivate me to use one over the other, I haven't looked deeply into redux.

the extent of my knowledge is that dispatch would be used for updating redux state, i'm not sure about if useEffect could be used for the same thing

* allow for redirection in associated objects skipping indices Signed-off-by: Paul Sebastian <[email protected]> * redirection in datasources table implemented Signed-off-by: Paul Sebastian <[email protected]> * moderate s3 callout changes Signed-off-by: Paul Sebastian <[email protected]> * lint complaint Signed-off-by: Paul Sebastian <[email protected]> * update snap Signed-off-by: Paul Sebastian <[email protected]> * fix discover to explorer url redirection Signed-off-by: Paul Sebastian <[email protected]> * include glue cache s3 callout Signed-off-by: Paul Sebastian <[email protected]> * update snapshot Signed-off-by: Paul Sebastian <[email protected]> * expand text area max length Signed-off-by: Paul Sebastian <[email protected]> * s3 no results page updated implementation Signed-off-by: Paul Sebastian <[email protected]> * open up acceleration flyout when direct query visualization Signed-off-by: Paul Sebastian <[email protected]> * update snapshots Signed-off-by: Paul Sebastian <[email protected]> * update one last snap Signed-off-by: Paul Sebastian <[email protected]> * fix lint complaint for a file i didnt even touch Signed-off-by: Paul Sebastian <[email protected]> --------- Signed-off-by: Paul Sebastian <[email protected]> (cherry picked from commit faf9c23) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* allow for redirection in associated objects skipping indices * redirection in datasources table implemented * moderate s3 callout changes * lint complaint * update snap * fix discover to explorer url redirection * include glue cache s3 callout * update snapshot * expand text area max length * s3 no results page updated implementation * open up acceleration flyout when direct query visualization * update snapshots * update one last snap * fix lint complaint for a file i didnt even touch --------- (cherry picked from commit faf9c23) Signed-off-by: Paul Sebastian <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…ject#1609) (cherry picked from commit d3b3f84d988e10d848cd8cd71828145d39c9768f) Co-authored-by: Darshit Chanpura <[email protected]>

…rch-project#1624) * allow for redirection in associated objects skipping indices * redirection in datasources table implemented * moderate s3 callout changes * lint complaint * update snap * fix discover to explorer url redirection * include glue cache s3 callout * update snapshot * expand text area max length * s3 no results page updated implementation * open up acceleration flyout when direct query visualization * update snapshots * update one last snap * fix lint complaint for a file i didnt even touch --------- (cherry picked from commit faf9c23) Signed-off-by: Paul Sebastian <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 256eeda)

paulstn added bug Something isn't working backport 2.x labels Mar 21, 2024

paulstn added 5 commits March 21, 2024 16:01

allow for redirection in associated objects skipping indices

2eef669

Signed-off-by: Paul Sebastian <[email protected]>

redirection in datasources table implemented

c190ed9

Signed-off-by: Paul Sebastian <[email protected]>

moderate s3 callout changes

1ebef73

Signed-off-by: Paul Sebastian <[email protected]>

lint complaint

a5b8912

Signed-off-by: Paul Sebastian <[email protected]>

update snap

e48ae4e

Signed-off-by: Paul Sebastian <[email protected]>

paulstn force-pushed the flint-bug-fix-redir-related branch from d6aa0ff to e48ae4e Compare March 21, 2024 23:01

paulstn added 3 commits March 22, 2024 13:41

fix discover to explorer url redirection

cc5a9f5

Signed-off-by: Paul Sebastian <[email protected]>

include glue cache s3 callout

e7a7200

Signed-off-by: Paul Sebastian <[email protected]>

update snapshot

0ea1b52

Signed-off-by: Paul Sebastian <[email protected]>

paulstn commented Mar 22, 2024

View reviewed changes

common/types/data_connections.ts Show resolved Hide resolved

paulstn requested a review from sejli March 25, 2024 17:24

paulstn added 6 commits March 25, 2024 11:12

expand text area max length

1520d4d

Signed-off-by: Paul Sebastian <[email protected]>

s3 no results page updated implementation

da1a405

Signed-off-by: Paul Sebastian <[email protected]>

open up acceleration flyout when direct query visualization

6780177

Signed-off-by: Paul Sebastian <[email protected]>

update snapshots

03caf94

Signed-off-by: Paul Sebastian <[email protected]>

update one last snap

ddada1c

Signed-off-by: Paul Sebastian <[email protected]>

fix lint complaint for a file i didnt even touch

e3fa247

Signed-off-by: Paul Sebastian <[email protected]>

paulstn marked this pull request as ready for review March 25, 2024 22:29

paulstn requested review from ps48, kavithacm, derek-ho, joshuali925, dai-chen, YANG-DB, rupal-bq, mengweieric and vamsimanohar as code owners March 25, 2024 22:29

paulstn requested review from Swiddis, penghuo, seankao-az, anirudha and sumukhswamy as code owners March 25, 2024 22:29

ps48 approved these changes Mar 25, 2024

View reviewed changes

ps48 added the backport 2.13 label Mar 25, 2024

Swiddis reviewed Mar 25, 2024

View reviewed changes

Swiddis approved these changes Mar 25, 2024

View reviewed changes

ps48 merged commit faf9c23 into opensearch-project:main Mar 25, 2024
16 of 23 checks passed

opensearch-trigger-bot bot mentioned this pull request Mar 25, 2024

[Backport 2.x] Fixed bugs in explorer redirection #1623

Merged

opensearch-trigger-bot bot mentioned this pull request Mar 25, 2024

[Backport 2.13] Fixed bugs in explorer redirection #1624

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed bugs in explorer redirection #1609

Fixed bugs in explorer redirection #1609

paulstn commented Mar 21, 2024 •

edited

Loading

codecov bot commented Mar 21, 2024 •

edited

Loading

Swiddis Mar 25, 2024

paulstn Mar 25, 2024

Swiddis Mar 25, 2024

paulstn Mar 25, 2024

		@@ -6,6 +6,8 @@

		import { BaseItem } from '@algolia/autocomplete-core';

		export const textAreaMaxLength = 16384;

Fixed bugs in explorer redirection #1609

Fixed bugs in explorer redirection #1609

Conversation

paulstn commented Mar 21, 2024 • edited Loading

Description

Issues Resolved

Check List

codecov bot commented Mar 21, 2024 • edited Loading

Codecov Report

Swiddis Mar 25, 2024

Choose a reason for hiding this comment

paulstn Mar 25, 2024

Choose a reason for hiding this comment

Swiddis Mar 25, 2024

Choose a reason for hiding this comment

paulstn Mar 25, 2024

Choose a reason for hiding this comment

paulstn commented Mar 21, 2024 •

edited

Loading

codecov bot commented Mar 21, 2024 •

edited

Loading