-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DSL router, update UI for query assist #1612
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sean Li <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1612 +/- ##
=======================================
Coverage 57.75% 57.76%
=======================================
Files 367 367
Lines 13825 13826 +1
Branches 3627 3626 -1
=======================================
+ Hits 7985 7986 +1
Misses 5777 5777
Partials 63 63
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
RyanL1997
approved these changes
Mar 23, 2024
Signed-off-by: Sean Li <[email protected]>
43939b1
to
6627169
Compare
Swiddis
approved these changes
Mar 25, 2024
ps48
approved these changes
Mar 25, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 25, 2024
* updating query assists UI, fixing DSL breaking change Signed-off-by: Sean Li <[email protected]> * adding dismissible to callouts Signed-off-by: Sean Li <[email protected]> --------- Signed-off-by: Sean Li <[email protected]> (cherry picked from commit fae6f09) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 25, 2024
* updating query assists UI, fixing DSL breaking change Signed-off-by: Sean Li <[email protected]> * adding dismissible to callouts Signed-off-by: Sean Li <[email protected]> --------- Signed-off-by: Sean Li <[email protected]> (cherry picked from commit fae6f09) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
pushed a commit
that referenced
this pull request
Mar 25, 2024
* updating query assists UI, fixing DSL breaking change * adding dismissible to callouts --------- (cherry picked from commit fae6f09) Signed-off-by: Sean Li <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
pushed a commit
that referenced
this pull request
Mar 25, 2024
* updating query assists UI, fixing DSL breaking change * adding dismissible to callouts --------- (cherry picked from commit fae6f09) Signed-off-by: Sean Li <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
…pensearch-project#1620) * updating query assists UI, fixing DSL breaking change * adding dismissible to callouts --------- (cherry picked from commit fae6f09) Signed-off-by: Sean Li <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit b98eb65)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cat.indices
is validated to have aformat
field andindex
field. Sincecat.indices
does not require anindex
field, I changed it to a maybe so that it doesn't break other components that call this API.Screen.Recording.2024-03-22.at.3.17.04.PM.mov
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.