Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DSL router, update UI for query assist #1612

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

sejli
Copy link
Member

@sejli sejli commented Mar 22, 2024

Description

  • In this PR, cat.indices is validated to have a format field and index field. Since cat.indices does not require an index field, I changed it to a maybe so that it doesn't break other components that call this API.
  • When query assist successfully generates PPL, display a callout.
  • Remove return button next to query assist input field.
Screen.Recording.2024-03-22.at.3.17.04.PM.mov

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.76%. Comparing base (3817476) to head (98fc5f5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1612   +/-   ##
=======================================
  Coverage   57.75%   57.76%           
=======================================
  Files         367      367           
  Lines       13825    13826    +1     
  Branches     3627     3626    -1     
=======================================
+ Hits         7985     7986    +1     
  Misses       5777     5777           
  Partials       63       63           
Flag Coverage Δ
dashboards-observability 57.76% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sejli sejli added bug Something isn't working backport 2.x backport 2.13 labels Mar 22, 2024
@sejli sejli force-pushed the query-assist-ui-update branch from 43939b1 to 6627169 Compare March 25, 2024 17:45
@ps48 ps48 merged commit fae6f09 into opensearch-project:main Mar 25, 2024
16 of 21 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 25, 2024
* updating query assists UI, fixing DSL breaking change

Signed-off-by: Sean Li <[email protected]>

* adding dismissible to callouts

Signed-off-by: Sean Li <[email protected]>

---------

Signed-off-by: Sean Li <[email protected]>
(cherry picked from commit fae6f09)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 25, 2024
* updating query assists UI, fixing DSL breaking change

Signed-off-by: Sean Li <[email protected]>

* adding dismissible to callouts

Signed-off-by: Sean Li <[email protected]>

---------

Signed-off-by: Sean Li <[email protected]>
(cherry picked from commit fae6f09)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48 pushed a commit that referenced this pull request Mar 25, 2024
* updating query assists UI, fixing DSL breaking change



* adding dismissible to callouts



---------


(cherry picked from commit fae6f09)

Signed-off-by: Sean Li <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48 pushed a commit that referenced this pull request Mar 25, 2024
* updating query assists UI, fixing DSL breaking change



* adding dismissible to callouts



---------


(cherry picked from commit fae6f09)

Signed-off-by: Sean Li <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
…pensearch-project#1620)

* updating query assists UI, fixing DSL breaking change

* adding dismissible to callouts

---------

(cherry picked from commit fae6f09)

Signed-off-by: Sean Li <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit b98eb65)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants