Add documentation for index.knn.faiss.efficient_filter.disable_exact_search setting#12286
Open
lawofcycles wants to merge 1 commit intoopensearch-project:mainfrom
Open
Conversation
…search setting This setting was added in opensearch-project/k-NN#3022 and released in OpenSearch 3.5. Changes: - Add the setting to the index settings table in settings.md - Add a new "Disabling the exact search fallback" subsection to the Faiss k-NN filter implementation section in efficient-knn-filtering.md Signed-off-by: Sotaro Hikita <bering1814@gmail.com>
lawofcycles
requested review from
cwperks,
dlvenable,
epugh,
kolchfa-aws,
mgodwan,
peterzhuamazon and
sumobrian
as code owners
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). |
Collaborator
|
@naveentatikonda Could you please review this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add documentation for the
index.knn.faiss.efficient_filter.disable_exact_searchindex setting, which was added in opensearch-project/k-NN#3022 and released in OpenSearch 3.5.This PR adds the setting to the index settings table in
settings.mdand adds a new "Disabling the exact search fallback" subsection to the Faiss k-NN filter implementation section inefficient-knn-filtering.md.Issues Resolved
N/A
Version
3.5
Frontend features
N/A
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.