Added a noop workflow step to delete model group (#376)

src/main/java/org/opensearch/flowframework/common/WorkflowResources.java

@@ -17,11 +17,12 @@
 import org.opensearch.flowframework.workflow.CreateIngestPipelineStep;
 import org.opensearch.flowframework.workflow.DeleteAgentStep;
 import org.opensearch.flowframework.workflow.DeleteConnectorStep;
+import org.opensearch.flowframework.workflow.DeleteModelGroupStep;
 import org.opensearch.flowframework.workflow.DeleteModelStep;
 import org.opensearch.flowframework.workflow.DeployModelStep;
-import org.opensearch.flowframework.workflow.ModelGroupStep;
 import org.opensearch.flowframework.workflow.RegisterAgentStep;
 import org.opensearch.flowframework.workflow.RegisterLocalModelStep;
+import org.opensearch.flowframework.workflow.RegisterModelGroupStep;
 import org.opensearch.flowframework.workflow.RegisterRemoteModelStep;
 import org.opensearch.flowframework.workflow.UndeployModelStep;
 
@@ -40,8 +41,8 @@ public enum WorkflowResources {
     REGISTER_REMOTE_MODEL(RegisterRemoteModelStep.NAME, WorkflowResources.MODEL_ID, DeleteModelStep.NAME),
     /** Workflow steps for registering/deleting a local model and associated created resource */
     REGISTER_LOCAL_MODEL(RegisterLocalModelStep.NAME, WorkflowResources.MODEL_ID, DeleteModelStep.NAME),
-    /** Workflow steps for registering a model group and associated created resource */
-    REGISTER_MODEL_GROUP(ModelGroupStep.NAME, WorkflowResources.MODEL_GROUP_ID, null), // TODO delete step
+    /** Workflow steps for registering/deleting a model group and associated created resource */
+    REGISTER_MODEL_GROUP(RegisterModelGroupStep.NAME, WorkflowResources.MODEL_GROUP_ID, DeleteModelGroupStep.NAME),
     /** Workflow steps for deploying/undeploying a model and associated created resource */
     DEPLOY_MODEL(DeployModelStep.NAME, WorkflowResources.MODEL_ID, UndeployModelStep.NAME),
     /** Workflow steps for creating an ingest-pipeline and associated created resource */

src/main/java/org/opensearch/flowframework/workflow/DeleteModelGroupStep.java

@@ -0,0 +1,40 @@
+/*
+ * Copyright OpenSearch Contributors
+ * SPDX-License-Identifier: Apache-2.0
+ *
+ * The OpenSearch Contributors require contributions made to
+ * this file be licensed under the Apache-2.0 license or a
+ * compatible open source license.
+ */
+package org.opensearch.flowframework.workflow;
+
+import java.util.Map;
+import java.util.concurrent.CompletableFuture;
+
+/**
+ * Step to delete a model group
+ */
+public class DeleteModelGroupStep implements WorkflowStep {
+
+    /** Instantiate this class */
+    public DeleteModelGroupStep() {}
+
+    /** The name of this step, used as a key in the template and the {@link WorkflowStepFactory} */
+    public static final String NAME = "delete_model_group";
+
+    @Override
+    public CompletableFuture<WorkflowData> execute(
+        String currentNodeId,
+        WorkflowData currentNodeInputs,
+        Map<String, WorkflowData> outputs,
+        Map<String, String> previousNodeInputs
+    ) {
+        return CompletableFuture.completedFuture(WorkflowData.EMPTY);
+    }
+
+    @Override
+    public String getName() {
+        return NAME;
+    }
+
+}

src/main/java/org/opensearch/flowframework/workflow/ModelGroupStep.java → src/main/java/org/opensearch/flowframework/workflow/RegisterModelGroupStep.java

@@ -39,9 +39,9 @@
 /**
  * Step to register a model group
  */
-public class ModelGroupStep implements WorkflowStep {
+public class RegisterModelGroupStep implements WorkflowStep {
 
-    private static final Logger logger = LogManager.getLogger(ModelGroupStep.class);
+    private static final Logger logger = LogManager.getLogger(RegisterModelGroupStep.class);
 
     private final MachineLearningNodeClient mlClient;
 
@@ -55,7 +55,7 @@ public class ModelGroupStep implements WorkflowStep {
      * @param mlClient client to instantiate MLClient
      * @param flowFrameworkIndicesHandler FlowFrameworkIndicesHandler class to update system indices
      */
-    public ModelGroupStep(MachineLearningNodeClient mlClient, FlowFrameworkIndicesHandler flowFrameworkIndicesHandler) {
+    public RegisterModelGroupStep(MachineLearningNodeClient mlClient, FlowFrameworkIndicesHandler flowFrameworkIndicesHandler) {
         this.mlClient = mlClient;
         this.flowFrameworkIndicesHandler = flowFrameworkIndicesHandler;
     }

src/main/java/org/opensearch/flowframework/workflow/WorkflowStepFactory.java

@@ -62,7 +62,8 @@ public WorkflowStepFactory(
         stepMap.put(UndeployModelStep.NAME, () -> new UndeployModelStep(mlClient));
         stepMap.put(CreateConnectorStep.NAME, () -> new CreateConnectorStep(mlClient, flowFrameworkIndicesHandler));
         stepMap.put(DeleteConnectorStep.NAME, () -> new DeleteConnectorStep(mlClient));
-        stepMap.put(ModelGroupStep.NAME, () -> new ModelGroupStep(mlClient, flowFrameworkIndicesHandler));
+        stepMap.put(RegisterModelGroupStep.NAME, () -> new RegisterModelGroupStep(mlClient, flowFrameworkIndicesHandler));
+        stepMap.put(DeleteModelGroupStep.NAME, DeleteModelGroupStep::new);
         stepMap.put(ToolStep.NAME, ToolStep::new);
         stepMap.put(RegisterAgentStep.NAME, () -> new RegisterAgentStep(mlClient, flowFrameworkIndicesHandler));
         stepMap.put(DeleteAgentStep.NAME, () -> new DeleteAgentStep(mlClient));

src/main/resources/mappings/workflow-steps.json

@@ -135,6 +135,11 @@
             "opensearch-ml"
         ]
     },
+    "delete_model_group": {
+        "inputs":[],
+        "outputs":[],
+        "required_plugins":[]
+    },
     "register_agent": {
         "inputs":[
             "name",

src/test/java/org/opensearch/flowframework/workflow/DeleteModelGroupTests.java

@@ -0,0 +1,31 @@
+/*
+ * Copyright OpenSearch Contributors
+ * SPDX-License-Identifier: Apache-2.0
+ *
+ * The OpenSearch Contributors require contributions made to
+ * this file be licensed under the Apache-2.0 license or a
+ * compatible open source license.
+ */
+package org.opensearch.flowframework.workflow;
+
+import org.opensearch.test.OpenSearchTestCase;
+
+import java.io.IOException;
+import java.util.Collections;
+import java.util.concurrent.CompletableFuture;
+
+public class DeleteModelGroupTests extends OpenSearchTestCase {
+
+    public void testDeleteModelGroup() throws IOException {
+        DeleteModelGroupStep deleteModelGroupStep = new DeleteModelGroupStep();
+        assertEquals(DeleteModelGroupStep.NAME, deleteModelGroupStep.getName());
+        CompletableFuture<WorkflowData> future = deleteModelGroupStep.execute(
+            "nodeId",
+            WorkflowData.EMPTY,
+            Collections.emptyMap(),
+            Collections.emptyMap()
+        );
+        assertTrue(future.isDone());
+        assertFalse(future.isCompletedExceptionally());
+    }
+}

src/test/java/org/opensearch/flowframework/workflow/ModelGroupStepTests.java

@@ -73,7 +73,7 @@ public void testRegisterModelGroup() throws ExecutionException, InterruptedExcep
         String modelGroupId = MODEL_GROUP_ID;
         String status = MLTaskState.CREATED.name();
 
-        ModelGroupStep modelGroupStep = new ModelGroupStep(machineLearningNodeClient, flowFrameworkIndicesHandler);
+        RegisterModelGroupStep modelGroupStep = new RegisterModelGroupStep(machineLearningNodeClient, flowFrameworkIndicesHandler);
 
         @SuppressWarnings("unchecked")
         ArgumentCaptor<ActionListener<MLRegisterModelGroupResponse>> actionListenerCaptor = ArgumentCaptor.forClass(ActionListener.class);
@@ -107,7 +107,7 @@ public void testRegisterModelGroup() throws ExecutionException, InterruptedExcep
     }
 
     public void testRegisterModelGroupFailure() throws IOException {
-        ModelGroupStep modelGroupStep = new ModelGroupStep(machineLearningNodeClient, flowFrameworkIndicesHandler);
+        RegisterModelGroupStep modelGroupStep = new RegisterModelGroupStep(machineLearningNodeClient, flowFrameworkIndicesHandler);
 
         @SuppressWarnings("unchecked")
         ArgumentCaptor<ActionListener<MLRegisterModelGroupResponse>> actionListenerCaptor = ArgumentCaptor.forClass(ActionListener.class);
@@ -135,7 +135,7 @@ public void testRegisterModelGroupFailure() throws IOException {
     }
 
     public void testRegisterModelGroupWithNoName() throws IOException {
-        ModelGroupStep modelGroupStep = new ModelGroupStep(machineLearningNodeClient, flowFrameworkIndicesHandler);
+        RegisterModelGroupStep modelGroupStep = new RegisterModelGroupStep(machineLearningNodeClient, flowFrameworkIndicesHandler);
 
         CompletableFuture<WorkflowData> future = modelGroupStep.execute(
             inputDataWithNoName.getNodeId(),