Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing tenantId to MLClient for Connector, Model and ModelGroup #1020

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

siddharthabingi
Copy link
Contributor

Description

Passing tenantId to MLClient for Connector, Model and ModelGroup

Related Issues

Integrate multitenancy into workflow provisioning

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.35%. Comparing base (1c16b1b) to head (3f7a230).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1020      +/-   ##
============================================
- Coverage     76.39%   76.35%   -0.05%     
  Complexity     1010     1010              
============================================
  Files           100      100              
  Lines          4881     4884       +3     
  Branches        455      455              
============================================
  Hits           3729     3729              
- Misses          955      959       +4     
+ Partials        197      196       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far. I think you can also do deploy and undeploy model steps.

And once PR is ready create and delete agent steps.

@dbwiddis dbwiddis merged commit 1375ee6 into opensearch-project:main Jan 25, 2025
22 of 23 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 25, 2025
Signed-off-by: Siddhartha Bingi <[email protected]>
Co-authored-by: Siddhartha Bingi <[email protected]>
(cherry picked from commit 1375ee6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis pushed a commit that referenced this pull request Jan 25, 2025
…ModelGroup (#1022)

Passing tenantId to MLClient for Connector, Model and ModelGroup (#1020)



(cherry picked from commit 1375ee6)

Signed-off-by: Siddhartha Bingi <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Siddhartha Bingi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport PRs to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants