Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update template for alert summary with new log pattern tools #1021

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Update template for alert summary with new log pattern tools #1021

merged 2 commits into from
Feb 6, 2025

Conversation

000FLMS
Copy link
Contributor

@000FLMS 000FLMS commented Jan 24, 2025 •
edited
Loading

Description

Update prompt and agent configuration for alert summary with new log pattern tools

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added the backport 2.x backport PRs to 2.x branch label Jan 24, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.53%. Comparing base (9671912) to head (cdf1290).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #1021   +/-   ##
=========================================
  Coverage     75.53%   75.53%           
  Complexity     1050     1050           
=========================================
  Files           101      101           
  Lines          5215     5215           
  Branches        498      498           
=========================================
  Hits           3939     3939           
  Misses         1038     1038           
  Partials        238      238

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@owaiskazi19
Copy link
Member

@000FLMS can you rebase with main and push again?

@000FLMS 000FLMS force-pushed the alert-log-pattern branch 3 times, most recently from ec9f0dc to 76aa0a0 Compare February 4, 2025 03:46
@owaiskazi19 owaiskazi19 merged commit 950437b into opensearch-project:main Feb 6, 2025
23 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 6, 2025
@github-actions
Update template for alert summary with new log pattern tools (#1021)
2a6ea7c 
* Update template for alert summary with log pattern

Signed-off-by: Sihan He <[email protected]>

* Update ChangeLog

Signed-off-by: Sihan He <[email protected]>

---------

Signed-off-by: Sihan He <[email protected]>
(cherry picked from commit 950437b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Feb 6, 2025
Closed
owaiskazi19
owaiskazi19 reviewed Feb 6, 2025
View reviewed changes
CHANGELOG.md
@@ -12,7 +12,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.1.0/)

### Documentation
- Add text to visualization agent template ([#936](https://github.com/opensearch-project/flow-framework/pull/936))

- Update template for alert summary with new log pattern tools ([#1021](https://github.com/opensearch-project/flow-framework/pull/1021))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@000FLMS This needs to be moved to unreleased 2.x version. Can you raise another PR to move this since this is merged?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, have raised a new PR here #1058

vAdyar pushed a commit to vAdyar/flow-framework that referenced this pull request Feb 8, 2025
@000FLMS @vAdyar
Update template for alert summary with new log pattern tools (opensea…
af06241 
…rch-project#1021)

* Update template for alert summary with log pattern

Signed-off-by: Sihan He <[email protected]>

* Update ChangeLog

Signed-off-by: Sihan He <[email protected]>

---------

Signed-off-by: Sihan He <[email protected]>
Signed-off-by: Vikas Adyar <[email protected]>
000FLMS pushed a commit to 000FLMS/flow-framework that referenced this pull request Feb 10, 2025
@github-actions @000FLMS
Update template for alert summary with new log pattern tools (opensea…
3469334 
…rch-project#1021)

* Update template for alert summary with log pattern

Signed-off-by: Sihan He <[email protected]>

* Update ChangeLog

Signed-off-by: Sihan He <[email protected]>

---------

Signed-off-by: Sihan He <[email protected]>
(cherry picked from commit 950437b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshpalis pushed a commit that referenced this pull request Feb 10, 2025
@vAdyar @siddharthabingi
@mend-for-github-com @000FLMS
1050: Reduce build warnings. (#1051)
2acbb56 
* Fixing unit tests related to mlclient getTask and adding integration test for workflow provisioning under multitenancy (#1045)

* Fixing unit tests related to  mlclient getTask

Signed-off-by: Siddhartha Bingi <[email protected]>

* Adding integration tests for workflow provisioning under multitenancy

Signed-off-by: Siddhartha Bingi <[email protected]>

* Addressing comments

Signed-off-by: Siddhartha Bingi <[email protected]>

---------

Signed-off-by: Siddhartha Bingi <[email protected]>
Co-authored-by: Siddhartha Bingi <[email protected]>
Signed-off-by: Vikas Adyar <[email protected]>

* chore(deps): update aws-actions/configure-aws-credentials action to v4.0.3 (#1029)

Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com>
Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com>
Signed-off-by: Vikas Adyar <[email protected]>

* fix(deps): update dependency com.google.code.gson:gson to v2.12.1 (#1035)

Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com>
Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com>
Signed-off-by: Vikas Adyar <[email protected]>

* 1050: * Changed the indentation from spaces to tab.
* Included private no-args constructors.
* refactoring.

Signed-off-by: Vikas Adyar <[email protected]>

* fix(deps): update dependency software.amazon.cryptography:aws-cryptographic-material-providers to v1.9.0 (#1047)

Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com>
Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com>
Signed-off-by: Vikas Adyar <[email protected]>

* chore(deps): update plugin org.gradle.test-retry to v1.6.2 (#1052)

Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com>
Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com>
Signed-off-by: Vikas Adyar <[email protected]>

* fix(deps): update dependency org.dafny:dafnyruntime to v4.10.0 (#1053)

Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com>
Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com>
Signed-off-by: Vikas Adyar <[email protected]>

* Update template for alert summary with new log pattern tools (#1021)

* Update template for alert summary with log pattern

Signed-off-by: Sihan He <[email protected]>

* Update ChangeLog

Signed-off-by: Sihan He <[email protected]>

---------

Signed-off-by: Sihan He <[email protected]>
Signed-off-by: Vikas Adyar <[email protected]>

* JDK 11 compatible changes.

Signed-off-by: Vikas Adyar <[email protected]>

---------

Signed-off-by: Siddhartha Bingi <[email protected]>
Signed-off-by: Vikas Adyar <[email protected]>
Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com>
Signed-off-by: Sihan He <[email protected]>
Co-authored-by: Siddhartha Bingi <[email protected]>
Co-authored-by: Siddhartha Bingi <[email protected]>
Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com>
Co-authored-by: 000FLMS <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 10, 2025
@github-actions @siddharthabingi
@mend-for-github-com @000FLMS
1050: Reduce build warnings. (#1051)
018750d 
* Fixing unit tests related to mlclient getTask and adding integration test for workflow provisioning under multitenancy (#1045)

* Fixing unit tests related to  mlclient getTask

Signed-off-by: Siddhartha Bingi <[email protected]>

* Adding integration tests for workflow provisioning under multitenancy

Signed-off-by: Siddhartha Bingi <[email protected]>

* Addressing comments

Signed-off-by: Siddhartha Bingi <[email protected]>

---------

Signed-off-by: Siddhartha Bingi <[email protected]>
Co-authored-by: Siddhartha Bingi <[email protected]>
Signed-off-by: Vikas Adyar <[email protected]>

* chore(deps): update aws-actions/configure-aws-credentials action to v4.0.3 (#1029)

Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com>
Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com>
Signed-off-by: Vikas Adyar <[email protected]>

* fix(deps): update dependency com.google.code.gson:gson to v2.12.1 (#1035)

Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com>
Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com>
Signed-off-by: Vikas Adyar <[email protected]>

* 1050: * Changed the indentation from spaces to tab.
* Included private no-args constructors.
* refactoring.

Signed-off-by: Vikas Adyar <[email protected]>

* fix(deps): update dependency software.amazon.cryptography:aws-cryptographic-material-providers to v1.9.0 (#1047)

Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com>
Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com>
Signed-off-by: Vikas Adyar <[email protected]>

* chore(deps): update plugin org.gradle.test-retry to v1.6.2 (#1052)

Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com>
Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com>
Signed-off-by: Vikas Adyar <[email protected]>

* fix(deps): update dependency org.dafny:dafnyruntime to v4.10.0 (#1053)

Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com>
Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com>
Signed-off-by: Vikas Adyar <[email protected]>

* Update template for alert summary with new log pattern tools (#1021)

* Update template for alert summary with log pattern

Signed-off-by: Sihan He <[email protected]>

* Update ChangeLog

Signed-off-by: Sihan He <[email protected]>

---------

Signed-off-by: Sihan He <[email protected]>
Signed-off-by: Vikas Adyar <[email protected]>

* JDK 11 compatible changes.

Signed-off-by: Vikas Adyar <[email protected]>

---------

Signed-off-by: Siddhartha Bingi <[email protected]>
Signed-off-by: Vikas Adyar <[email protected]>
Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com>
Signed-off-by: Sihan He <[email protected]>
Co-authored-by: Siddhartha Bingi <[email protected]>
Co-authored-by: Siddhartha Bingi <[email protected]>
Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com>
Co-authored-by: 000FLMS <[email protected]>
(cherry picked from commit 2acbb56)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshpalis pushed a commit that referenced this pull request Feb 10, 2025
@000FLMS @github-actions
[Backport 2.x] Update template for alert summary with new log pattern…
3a0880d 
… tools (#1021) (#1059)

Update template for alert summary with new log pattern tools (#1021)

* Update template for alert summary with log pattern



* Update ChangeLog



---------


(cherry picked from commit 950437b)

Signed-off-by: Sihan He <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshpalis pushed a commit that referenced this pull request Feb 10, 2025
@opensearch-trigger-bot @github-actions
@siddharthabingi @mend-for-github-com @000FLMS
[Backport 2.x] 1050: Reduce build warnings. (#1060)
13dc5c5 
1050:  Reduce build warnings. (#1051)

* Fixing unit tests related to mlclient getTask and adding integration test for workflow provisioning under multitenancy (#1045)

* Fixing unit tests related to  mlclient getTask



* Adding integration tests for workflow provisioning under multitenancy



* Addressing comments



---------





* chore(deps): update aws-actions/configure-aws-credentials action to v4.0.3 (#1029)





* fix(deps): update dependency com.google.code.gson:gson to v2.12.1 (#1035)





* 1050: * Changed the indentation from spaces to tab.
* Included private no-args constructors.
* refactoring.



* fix(deps): update dependency software.amazon.cryptography:aws-cryptographic-material-providers to v1.9.0 (#1047)





* chore(deps): update plugin org.gradle.test-retry to v1.6.2 (#1052)





* fix(deps): update dependency org.dafny:dafnyruntime to v4.10.0 (#1053)





* Update template for alert summary with new log pattern tools (#1021)

* Update template for alert summary with log pattern



* Update ChangeLog



---------




* JDK 11 compatible changes.



---------









(cherry picked from commit 2acbb56)

Signed-off-by: Siddhartha Bingi <[email protected]>
Signed-off-by: Vikas Adyar <[email protected]>
Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com>
Signed-off-by: Sihan He <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Siddhartha Bingi <[email protected]>
Co-authored-by: Siddhartha Bingi <[email protected]>
Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com>
Co-authored-by: 000FLMS <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owaiskazi19 owaiskazi19 owaiskazi19 approved these changes

@dbwiddis dbwiddis dbwiddis approved these changes

@joshpalis joshpalis Awaiting requested review from joshpalis joshpalis is a code owner

@ohltyler ohltyler Awaiting requested review from ohltyler ohltyler is a code owner

@amitgalitz amitgalitz Awaiting requested review from amitgalitz amitgalitz is a code owner

@jackiehanyang jackiehanyang Awaiting requested review from jackiehanyang jackiehanyang is a code owner

Assignees
No one assigned
Labels
backport 2.x backport PRs to 2.x branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@000FLMS @owaiskazi19 @dbwiddis