1050: Reduce build warnings.

[vAdyar]

Description

• Changed the indentation from spaces to tab.
• Included private no-args constructors.
• refactoring.

Related Issues

Resolves #1050

Check List

• New functionality includes testing.
• New functionality has been documented.
• [ ] API changes companion pull request created.
• Commits are signed per the DCO using --signoff.
• [ ] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.57%. Comparing base (950437b) to head (fae5e7c).
Report is 2 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #1051      +/-   ##
============================================
+ Coverage     75.53%   75.57%   +0.04%     
  Complexity     1050     1050              
============================================
  Files           101      101              
  Lines          5215     5212       -3     
  Branches        498      498              
============================================
  Hits           3939     3939              
+ Misses         1038     1035       -3     
  Partials        238      238              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dbwiddis]

Hey @vAdyar thanks for contributing! The addition of the private constructors and change of private variable look great.

Changed the indentation from spaces to tab.

The intent is not to change the formatting, but just to change the name of the parameter used to control it, specifically this line:

flow-framework/formatter/formatting.gradle

Line 38 in 9671912

indentWithSpaces()

We don't want tabs. That line converts all tabs to spaces (good) but the name of the parameter has changed.

Some hints:

• after making any changes, run the command line ./gradlew spotlessApply to format your code.
• you need to use DCO to signoff each commit. Most editors have a little check box you can select to add the SIgned-off-by line. Or you can use the -s switch if committing from the command line. You can sign off the immediate previous commits with git commit -s --amend assuming you've set up your name and email in git. See https://github.com/opensearch-project/flow-framework/blob/main/CONTRIBUTING.md#developer-certificate-of-origin

[vAdyar]

@dbwiddis I've signed off my latest comment as mentioned in the document. I'm still somehow seeing the DCO check getting failed. Any clue on this?

[dbwiddis]

@dbwiddis I've signed off my latest comment as mentioned in the document. I'm still somehow seeing the DCO check getting failed. Any clue on this?

You can click on the failed check and scroll to the bottom: https://github.com/opensearch-project/flow-framework/pull/1051/checks?check_run_id=36856487375

Looks like you have your name but not an email address there.

[vAdyar]

@dbwiddis Looks like all check are fine. Can you review again?

[dbwiddis]

@dbwiddis Looks like all check are fine. Can you review again?

Well the DCO passes and spotless does too, but you still haven't backed out the JDK21 changes to APISpecFetcher or changed the name of indentWithSpaces to leadingTabsToSpaces. :)

[vAdyar]

My bad it wasn't rebased properly! Rebased the PR. :)

[dbwiddis]

LGTM!

[joshpalis]

Thank you for your contribution @vAdyar! Changes look good to me