Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize id_map as null #1363

Merged
merged 1 commit into from
Dec 28, 2023
Merged

Initialize id_map as null #1363

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions jni/patches/faiss/0001-Custom-patch-to-support-multi-vector.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
From 70c9b5d6408bb85fd1503002d29f9428fe0d48dc Mon Sep 17 00:00:00 2001
From baa7e23c54637d68adac45f09633939b402405a9 Mon Sep 17 00:00:00 2001
From: Heemin Kim <[email protected]>
Date: Wed, 6 Dec 2023 16:33:52 -0800
Subject: [PATCH] Custom patch to support multi-vector
Expand Down Expand Up @@ -259,7 +259,7 @@ index 00000000..a0489fd6
+} // namespace faiss
diff --git a/faiss/impl/ResultCollectorFactory.h b/faiss/impl/ResultCollectorFactory.h
new file mode 100644
index 00000000..70918266
index 00000000..b460b20b
--- /dev/null
+++ b/faiss/impl/ResultCollectorFactory.h
@@ -0,0 +1,33 @@
Expand All @@ -277,7 +277,7 @@ index 00000000..70918266
+/** ResultCollectorFactory to create a ResultCollector object */
+struct ResultCollectorFactory {
+ DefaultCollector default_collector;
+ const std::vector<int64_t>* id_map;
+ const std::vector<int64_t>* id_map = nullptr;
+
+ // Create a new ResultCollector object
+ virtual ResultCollector* new_collector() {
Expand Down
Loading