Update spotless and eclipse dependencies #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
ryanbogan
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1450 +/- ##
============================================
- Coverage 85.07% 85.05% -0.02%
+ Complexity 1278 1277 -1
============================================
Files 167 167
Lines 5207 5207
Branches 493 493
============================================
- Hits 4430 4429 -1
Misses 570 570
- Partials 207 208 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ryan Bogan <[email protected]>
ryanbogan
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei and
martin-gaievski
as code owners
Signed-off-by: Ryan Bogan <[email protected]>
vibrantvarun
approved these changes
Feb 5, 2024
Signed-off-by: Ryan Bogan <[email protected]>
naveentatikonda
approved these changes
Feb 5, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 5, 2024
* Update spotless and eclipse dependencies Signed-off-by: Ryan Bogan <[email protected]> * Update dependencies for spotless and eclipse Signed-off-by: Ryan Bogan <[email protected]> * Add Changelog Signed-off-by: Ryan Bogan <[email protected]> * Add comment Signed-off-by: Ryan Bogan <[email protected]> * Add resources force resolution for eclipse Signed-off-by: Ryan Bogan <[email protected]> --------- Signed-off-by: Ryan Bogan <[email protected]> (cherry picked from commit fceb8f8)
ryanbogan
added a commit
that referenced
this pull request
Feb 5, 2024
* Update spotless and eclipse dependencies Signed-off-by: Ryan Bogan <[email protected]> * Update dependencies for spotless and eclipse Signed-off-by: Ryan Bogan <[email protected]> * Add Changelog Signed-off-by: Ryan Bogan <[email protected]> * Add comment Signed-off-by: Ryan Bogan <[email protected]> * Add resources force resolution for eclipse Signed-off-by: Ryan Bogan <[email protected]> --------- Signed-off-by: Ryan Bogan <[email protected]> (cherry picked from commit fceb8f8) Co-authored-by: Ryan Bogan <[email protected]>
|
A bit late to review this as it's been merged/released but only really effects running spotless. The GHSA stating 4.29 is in error. The latest version of eclipse runtime is 3.30, the latest of eclipse resources is 3.20. I suspect spotless would fail if you tried to run it on this branch now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates dependencies to fix CVEs
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.