[Backport 2.x] Ensure consistent filter query in KNNQueryBuilder across multiple shards #2362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…rds (#2359) * Changed filter logic Signed-off-by: Sahil Buddharaju <[email protected]> * spotless Signed-off-by: Sahil Buddharaju <[email protected]> * Changelog Signed-off-by: Sahil Buddharaju <[email protected]> * Added unit tests to test multi shard filters Signed-off-by: Sahil Buddharaju <[email protected]> * Changed unit tests and used builder instead of constructor Signed-off-by: Sahil Buddharaju <[email protected]> * Spotless apply Signed-off-by: Sahil Buddharaju <[email protected]> * slight unit test adjustment Signed-off-by: Sahil Buddharaju <[email protected]> * changelog Signed-off-by: Sahil Buddharaju <[email protected]> --------- Signed-off-by: Sahil Buddharaju <[email protected]> Signed-off-by: sahil <[email protected]> Co-authored-by: Sahil Buddharaju <[email protected]> (cherry picked from commit c969f1d)
opensearch-trigger-bot
bot
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan and
luyuncheng
as code owners
navneet1v
added
the
Bug Fixes
navneet1v
approved these changes
Jan 3, 2025
|
@shatejas , @jmazanec15 can one of you approve and merge this backport PR |
jmazanec15
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport c969f1d from #2359