[Backport Main] Add path.repo for registering snapshot repository in integ tests #2463
+5
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntians
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan,
luyuncheng,
shatejas and
0ctopus13prime
as code owners
|
This PR is a fix for a previous PR #2445. Can I get help with adding the |
anntians
changed the title
sohami
approved these changes
Jan 30, 2025
anntians
force-pushed
the
backport/backport-2461-to-main
branch
from
2dc6738 to
a9ed1db
Compare
sohami
reviewed
Jan 31, 2025
| @@ -53,7 +53,7 @@ public class ModelIT extends AbstractRestartUpgradeTestCase { | |||
| private static final int DELAY_MILLI_SEC = 1000; | |||
| private static final int MIN_NUM_OF_MODELS = 2; | |||
| private static final int K = 5; | |||
| private static final int NUM_DOCS = 10; | |||
| private static final int NUM_DOCS = 1100; | |||
There was a problem hiding this comment.
why is this change needed ? Don't see any correlation with this PR
There was a problem hiding this comment.
This change is related to another backport PR #2443 about updating error messages for faiss training. That other backport PR made the same fix as above, but it hasn't been merged yet, which is why I made this change in this PR to get the tests passing
There was a problem hiding this comment.
Got it. We should not make it as part of this PR then and let other PR merge, then rebase this PR on top of it before merging.
|
@anntians Can you please rebase? |
…nsearch-project#2461) Signed-off-by: AnnTian Shao <[email protected]> Co-authored-by: AnnTian Shao <[email protected]> (cherry picked from commit 168ee3c)
anntians
force-pushed
the
backport/backport-2461-to-main
branch
from
6bd941a to
06a292f
Compare
anntians
force-pushed
the
backport/backport-2461-to-main
branch
from
06a292f to
88c230e
Compare
Signed-off-by: AnnTian Shao <[email protected]>
anntians
force-pushed
the
backport/backport-2461-to-main
branch
3 times, most recently
from
019a8d2 to
bc9dbe9
Compare
Signed-off-by: Tommy Shao <[email protected]> Signed-off-by: AnnTian Shao <[email protected]>
anntians
force-pushed
the
backport/backport-2461-to-main
branch
from
bc9dbe9 to
8c032b8
Compare
jmazanec15
approved these changes
Feb 26, 2025
naveentatikonda
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A prior PR #2445 was breaking the release build of 2.19 due to #2458. This PR fixes the issue by updating the path.repo used to register snapshot repositories in integ tests
Related Issues
Resolves #2458
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.