Clean JNI artifacts with ./gradlew clean

[sam-herman]

Description

More build tidiness changes:

1. Clean JNI artifacts with ./gradlew clean to make local builds idempotent and more reliable.
2. Places release under binary_dir instead of under source_dir this makes all artifacts only show up under single directory without the need to hunt them down in multiple places when cleaning up.
3. Switch to cmake instead of make when building native JNI for improved readability

Related Issues

Resolves #2515

Check List

• New functionality includes testing.
• New functionality has been documented.
• API changes companion pull request created.
• Commits are signed per the DCO using --signoff.
• Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[navneet1v]

can we not just remove build folder here, since with your earlier change you moved all these files to the build folder

[sam-herman]

I think Release is still out there, I can see if I can add it under the build folder

[sam-herman]

But you're right, the rest are not needed other than build and release

[sam-herman]

@navneet1v should be good now on the paths, let me know.

[naveentatikonda]

@sam-herman do you know why we are not able to see the build logs of faiss on Linux after your change while it is logged for other OS?

With these logs how do we know which version of faiss library(avx2, avx512, etc) are we building. Can you atleast list all the libraries that were built at the end of make so that it will be easy to debug if something goes wrong while loading the library during runtime ?

Logs on Linux

> Task :buildJniLib
/__w/k-NN/k-NN/jni/src/org_opensearch_knn_jni_FaissService.cpp: In function 'jlong Java_org_opensearch_knn_jni_FaissService_loadIndex(JNIEnv*, jclass, jstring)':
/__w/k-NN/k-NN/jni/src/org_opensearch_knn_jni_FaissService.cpp:245:10: warning: converting to non-pointer type 'long int' from NULL [-Wconversion-null]
  245 |   return NULL;
      |          ^~~~
/__w/k-NN/k-NN/jni/src/org_opensearch_knn_jni_FaissService.cpp: In function 'jlong Java_org_opensearch_knn_jni_FaissService_loadIndexWithStream(JNIEnv*, jclass, jobject)':
/__w/k-NN/k-NN/jni/src/org_opensearch_knn_jni_FaissService.cpp:267:12: warning: converting to non-pointer type 'long int' from NULL [-Wconversion-null]
  267 |     return NULL;
      |            ^~~~
/__w/k-NN/k-NN/jni/src/org_opensearch_knn_jni_FaissService.cpp: In function 'jlong Java_org_opensearch_knn_jni_FaissService_loadBinaryIndex(JNIEnv*, jclass, jstring)':
/__w/k-NN/k-NN/jni/src/org_opensearch_knn_jni_FaissService.cpp:277:12: warning: converting to non-pointer type 'long int' from NULL [-Wconversion-null]
  277 |     return NULL;
      |            ^~~~
/__w/k-NN/k-NN/jni/src/org_opensearch_knn_jni_FaissService.cpp: In function 'jlong Java_org_opensearch_knn_jni_FaissService_loadBinaryIndexWithStream(JNIEnv*, jclass, jobject)':
/__w/k-NN/k-NN/jni/src/org_opensearch_knn_jni_FaissService.cpp:299:12: warning: converting to non-pointer type 'long int' from NULL [-Wconversion-null]
  299 |     return NULL;
      |            ^~~~
/__w/k-NN/k-NN/jni/src/org_opensearch_knn_jni_FaissService.cpp: In function 'jboolean Java_org_opensearch_knn_jni_FaissService_isSharedIndexStateRequired(JNIEnv*, jclass, jlong)':
/__w/k-NN/k-NN/jni/src/org_opensearch_knn_jni_FaissService.cpp:311:12: warning: converting to non-pointer type 'jboolean' {aka 'unsigned char'} from NULL [-Wconversion-null]
  311 |     return NULL;
      |            ^~~~
/__w/k-NN/k-NN/jni/src/org_opensearch_knn_jni_FaissService.cpp: In function 'jlong Java_org_opensearch_knn_jni_FaissService_initSharedIndexState(JNIEnv*, jclass, jlong)':
/__w/k-NN/k-NN/jni/src/org_opensearch_knn_jni_FaissService.cpp:322:12: warning: converting to non-pointer type 'long int' from NULL [-Wconversion-null]
  322 |     return NULL;
      |            ^~~~

[sam-herman]

@sam-herman do you know why we are not able to see the build logs of faiss on Linux after your change while it is logged for other OS?

With these logs how do we know which version of faiss library(avx2, avx512, etc) are we building. Can you atleast list all the libraries that were built at the end of make so that it will be easy to debug if something goes wrong while loading the library during runtime ?

Logs on Linux

> Task :buildJniLib
/__w/k-NN/k-NN/jni/src/org_opensearch_knn_jni_FaissService.cpp: In function 'jlong Java_org_opensearch_knn_jni_FaissService_loadIndex(JNIEnv*, jclass, jstring)':
/__w/k-NN/k-NN/jni/src/org_opensearch_knn_jni_FaissService.cpp:245:10: warning: converting to non-pointer type 'long int' from NULL [-Wconversion-null]
  245 |   return NULL;
      |          ^~~~
/__w/k-NN/k-NN/jni/src/org_opensearch_knn_jni_FaissService.cpp: In function 'jlong Java_org_opensearch_knn_jni_FaissService_loadIndexWithStream(JNIEnv*, jclass, jobject)':
/__w/k-NN/k-NN/jni/src/org_opensearch_knn_jni_FaissService.cpp:267:12: warning: converting to non-pointer type 'long int' from NULL [-Wconversion-null]
  267 |     return NULL;
      |            ^~~~
/__w/k-NN/k-NN/jni/src/org_opensearch_knn_jni_FaissService.cpp: In function 'jlong Java_org_opensearch_knn_jni_FaissService_loadBinaryIndex(JNIEnv*, jclass, jstring)':
/__w/k-NN/k-NN/jni/src/org_opensearch_knn_jni_FaissService.cpp:277:12: warning: converting to non-pointer type 'long int' from NULL [-Wconversion-null]
  277 |     return NULL;
      |            ^~~~
/__w/k-NN/k-NN/jni/src/org_opensearch_knn_jni_FaissService.cpp: In function 'jlong Java_org_opensearch_knn_jni_FaissService_loadBinaryIndexWithStream(JNIEnv*, jclass, jobject)':
/__w/k-NN/k-NN/jni/src/org_opensearch_knn_jni_FaissService.cpp:299:12: warning: converting to non-pointer type 'long int' from NULL [-Wconversion-null]
  299 |     return NULL;
      |            ^~~~
/__w/k-NN/k-NN/jni/src/org_opensearch_knn_jni_FaissService.cpp: In function 'jboolean Java_org_opensearch_knn_jni_FaissService_isSharedIndexStateRequired(JNIEnv*, jclass, jlong)':
/__w/k-NN/k-NN/jni/src/org_opensearch_knn_jni_FaissService.cpp:311:12: warning: converting to non-pointer type 'jboolean' {aka 'unsigned char'} from NULL [-Wconversion-null]
  311 |     return NULL;
      |            ^~~~
/__w/k-NN/k-NN/jni/src/org_opensearch_knn_jni_FaissService.cpp: In function 'jlong Java_org_opensearch_knn_jni_FaissService_initSharedIndexState(JNIEnv*, jclass, jlong)':
/__w/k-NN/k-NN/jni/src/org_opensearch_knn_jni_FaissService.cpp:322:12: warning: converting to non-pointer type 'long int' from NULL [-Wconversion-null]
  322 |     return NULL;
      |            ^~~~

It should show, I'll try to build on a linux machine to debug this one. Will make updates

[sam-herman]

@naveentatikonda I fixed the logging issue on linux and tested, see the last commit on this change.