-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional technical writer feedback to Cluster APIs #824
base: main
Are you sure you want to change the base?
Add additional technical writer feedback to Cluster APIs #824
Conversation
Signed-off-by: Archer <[email protected]>
Signed-off-by: Archer <[email protected]>
Changes AnalysisCommit SHA: 1b9f37c API ChangesSummary
ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/13550673600/artifacts/2658017533 API Coverage
|
Signed-off-by: Archer <[email protected]>
Signed-off-by: Archer <[email protected]>
Signed-off-by: Archer <[email protected]>
Spec Test Coverage Analysis
|
Adding Missing Defaults and changing |
Signed-off-by: Archer <[email protected]>
All checks are passing. |
@@ -973,6 +978,7 @@ components: | |||
required: true | |||
cluster.get_settings::query.cluster_manager_timeout: | |||
name: cluster_manager_timeout | |||
description: The amount of time to wait for a response from the cluster manager node. For more information about supported time units, see [Common parameters]({{site.url}}{{site.baseurl}}/api-reference/common-parameters/#time-units). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spec is being used by different applications, like codegen to generate api methods for different OpenSearch clients. So having something that's only usable on the docs website like {{site.url}}{{site.baseurl}}
is not good. We already have the ability replace https://opensearch.org/docs/latest
with {{site.url}}{{site.baseurl}}
in the docs tooling here: https://github.com/opensearch-project/documentation-website/blob/main/spec-insert/config.yml#L11
@@ -1033,6 +1039,7 @@ components: | |||
cluster.health::query.cluster_manager_timeout: | |||
name: cluster_manager_timeout | |||
in: query | |||
description: The amount of time to wait for a response from the cluster manager node. For more information about supported time units, see [Common parameters]({{site.url}}{{site.baseurl}}/api-reference/common-parameters/#time-units). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue as above.
I've looked into the Vale error. Looks like a bug on Vale's end. I've created an issue on their repo here. |
This PR will handle the Vale failure |
This PR adds descriptions for certain enums and array options that exist for Cluster APIs. Also adds defaults where they might not exist, and makes some descriptions more descriptive.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.