Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flow Framework] Update sample input to JSON lines format #1732

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Flow Framework] Update sample input to JSON lines format #1732

wants to merge 1 commit into from
+8 −31

Conversation

ohltyler
Copy link
Member

Description

opensearch-project/dashboards-flow-framework#639 updates the source input file format to JSON lines. This PR updates the sample input accordingly.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ohltyler ohltyler mentioned this pull request Feb 21, 2025
Merged
1 task
@ohltyler ohltyler marked this pull request as draft February 21, 2025 21:05
@ohltyler
Copy link
Member Author

ohltyler commented Feb 21, 2025 •
edited
Loading

Passed on local against 2.x (consistent with main):

✓ Create workflow using semantic search template (684987ms)

@ohltyler ohltyler marked this pull request as ready for review February 24, 2025 17:37
saimedhi
saimedhi approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@saimedhi saimedhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CCongWang CCongWang CCongWang approved these changes

@saimedhi saimedhi saimedhi approved these changes

@tianleh tianleh Awaiting requested review from tianleh tianleh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@peterzhuamazon peterzhuamazon Awaiting requested review from peterzhuamazon peterzhuamazon is a code owner

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@prudhvigodithi prudhvigodithi Awaiting requested review from prudhvigodithi prudhvigodithi is a code owner

@xluo-aws xluo-aws Awaiting requested review from xluo-aws xluo-aws is a code owner

@Hailong-am Hailong-am Awaiting requested review from Hailong-am Hailong-am is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@wanglam wanglam Awaiting requested review from wanglam wanglam is a code owner

@raintygao raintygao Awaiting requested review from raintygao raintygao is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@yujin-emma yujin-emma Awaiting requested review from yujin-emma yujin-emma is a code owner

@yubonluo yubonluo Awaiting requested review from yubonluo yubonluo is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
backport 2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ohltyler @CCongWang @saimedhi