Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock version of OpenSearch for integration tests. #667

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

dblock
Copy link
Member

@dblock dblock commented Feb 12, 2025

Description

Lock version of OpenSearch for integration tests. When 2.19 was released it broke CI, which is not desirable. With this change we have to upgrade deliberately like we do for integration tests already.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.66%. Comparing base (06a6dc8) to head (d836c4a).
Report is 85 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #667      +/-   ##
==========================================
+ Coverage   57.29%   62.66%   +5.37%     
==========================================
  Files         315      376      +61     
  Lines        9823    11133    +1310     
==========================================
+ Hits         5628     6977    +1349     
+ Misses       2902     2876      -26     
+ Partials     1293     1280      -13     
Flag Coverage Δ
integration 54.87% <ø> (+4.03%) ⬆️
unit 15.48% <ø> (+2.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 31 files with indirect coverage changes

@Jakob3xD
Copy link
Collaborator

@dblock #669 fixes the CI issue. Do you still want to lock the version?

@dblock
Copy link
Member Author

dblock commented Feb 12, 2025

@dblock #669 fixes the CI issue. Do you still want to lock the version?

We should lock the version to avoid getting randomized, yes. Want to do it part of #669?

I locked it to 2.19 in this PR.

@dblock dblock merged commit a0874c8 into opensearch-project:main Feb 12, 2025
61 checks passed
@dblock dblock deleted the test-2.18 branch February 12, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants