Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inner hits support #672

Merged
merged 3 commits into from
Feb 22, 2025
Merged

Conversation

MaximMolchanov
Copy link
Contributor

Description

Added inner hits param support

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.66%. Comparing base (06a6dc8) to head (b30a43b).
Report is 88 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #672      +/-   ##
==========================================
+ Coverage   57.29%   62.66%   +5.37%     
==========================================
  Files         315      376      +61     
  Lines        9823    11133    +1310     
==========================================
+ Hits         5628     6977    +1349     
+ Misses       2902     2876      -26     
+ Partials     1293     1280      -13     
Flag Coverage Δ
integration 54.87% <ø> (+4.03%) ⬆️
unit 15.48% <ø> (+2.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
opensearchapi/api_search.go 100.00% <ø> (ø)

... and 31 files with indirect coverage changes

@dblock
Copy link
Member

dblock commented Feb 21, 2025

@MaximMolchanov thanks! amend your commit with -s for DCO please, and look at failing tests?

@MaximMolchanov MaximMolchanov force-pushed the inner-hits branch 2 times, most recently from 7c10846 to 29e266f Compare February 21, 2025 14:58
@MaximMolchanov
Copy link
Contributor Author

@MaximMolchanov thanks! amend your commit with -s for DCO please, and look at failing tests?

Tried to sign and force push with update, pls take a look. Some checks are failed, but I think I've done what I can

@dblock
Copy link
Member

dblock commented Feb 21, 2025

@MaximMolchanov DCO is still failing because all commits have to be signed, not just the last one, so you'd need to re-push all. Squash and force push may be easier.

@MaximMolchanov
Copy link
Contributor Author

@MaximMolchanov DCO is still failing because all commits have to be signed, not just the last one, so you'd need to re-push all. Squash and force push may be easier.

But I've resigned all three

@dblock
Copy link
Member

dblock commented Feb 21, 2025

Oh, it's a config problem.

Commit sha: [75d0fcf](https://github.com/opensearch-project/opensearch-go/pull/672/commits/75d0fcf3f9c92344a55f0e709e2809cb6dc73c12), Author: Maksym Molchanov, Committer: Maksym Molchanov; Expected "Maksym Molchanov [[email protected]](mailto:[email protected])", but got "Maxim Molchanov [[email protected]](mailto:[email protected])".

The signature has to match the email of the commit, your local git config is different I think?

Signed-off-by: Maxim Molchanov <[email protected]>
Signed-off-by: Maxim Molchanov <[email protected]>
Signed-off-by: Maxim Molchanov <[email protected]>
@MaximMolchanov
Copy link
Contributor Author

Oh, it's a config problem.

Commit sha: [75d0fcf](https://github.com/opensearch-project/opensearch-go/pull/672/commits/75d0fcf3f9c92344a55f0e709e2809cb6dc73c12), Author: Maksym Molchanov, Committer: Maksym Molchanov; Expected "Maksym Molchanov [[email protected]](mailto:[email protected])", but got "Maxim Molchanov [[email protected]](mailto:[email protected])".

The signature has to match the email of the commit, your local git config is different I think?

Ok, now should work. I think I've resigned them finally :)

@dblock dblock merged commit 613f7ee into opensearch-project:main Feb 22, 2025
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants