-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle HTTP exceptions in HttpTransport #254
Handle HTTP exceptions in HttpTransport #254
Conversation
520cd4e
to
ff70623
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I think PHPStan is right to complain on its warnings in src/OpenSearch/Client.php.
f99404f
to
12c5ea2
Compare
Test fails are due to #255 |
12c5ea2
to
b0867d9
Compare
Signed-off-by: Kim Pepper <[email protected]>
75ce0d6
to
fff8698
Compare
Signed-off-by: Kim Pepper <[email protected]>
fff8698
to
66e7996
Compare
Not sure about the code coverage report fails. We are adding tests here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
Description
As discussed in #251 (comment) we agreed that we should keep the existing behaviour of throwing exceptions.
This PR:
Issues Resolved
#250
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.