Ensure Async mode is still working on last version, Fix #297 #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainruaud
requested review from
VachaShah,
dblock,
harshavamsi,
shyim,
saimedhi and
kimpepper
as code owners
romainruaud
force-pushed
the
fix_async-mode
branch
from
ed311c2 to
36a5d1b
Compare
Signed-off-by: Romain Ruaud <[email protected]>
romainruaud
force-pushed
the
fix_async-mode
branch
from
36a5d1b to
9dd5111
Compare
kimpepper
reviewed
Feb 17, 2025
| @@ -2155,7 +2155,7 @@ public function request( | |||
| string $method, | |||
| string $uri, | |||
| array $attributes = [] | |||
| ): array|string|null { | |||
| ): \Traversable|array|string|null { | |||
There was a problem hiding this comment.
Should this just be iterable instead of \Traversable|array?
There was a problem hiding this comment.
yep I agree, iterable is probably cleaner
|
Fixed in #300 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The explicit call to
wait()in LegacyTransportWrapper was causing all the existing promises to resolve even if we plan to let them run async.The missing parameter for
performRequestandresultOrFuturewas also preventing the correct detection that we are using the async mode.Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
#297
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.