Update performRequest return type to iterable #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimpepper
requested review from
VachaShah,
dblock,
harshavamsi,
shyim and
saimedhi
as code owners
Signed-off-by: Kim Pepper <[email protected]>
kimpepper
force-pushed
the
update-client-iterable
branch
from
8e7e923 to
84e3613
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #313 +/- ##
============================================
+ Coverage 23.57% 23.87% +0.29%
- Complexity 3614 3623 +9
============================================
Files 534 538 +4
Lines 13797 13856 +59
============================================
+ Hits 3253 3308 +55
- Misses 10544 10548 +4 ☔ View full report in Codecov by Sentry. |
dblock
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes the return type of performRequest() to iterable for BC. It was only partially fixed in #308 as the client template wasn't changed, so the next API update will revert it.
Issues Resolved
Fixes #307
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.