Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nmslib and lucene dashboard to website #2872

Merged
merged 1 commit into from
May 20, 2024

Conversation

VijayanB
Copy link
Member

Description

Use share-> Embed code to copy dashboards from https://benchmarks.opensearch.org/ to be available as part of website

Issues Resolved

#2871

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

Use share-> Embed code to copy dashboards from https://benchmarks.opensearch.org/ to  be available as part of website

Signed-off-by: Vijayan Balasubramanian <[email protected]>
Copy link
Contributor

@rishabh6788 rishabh6788 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@nateynateynate Can you please approve and merge this PR?

@rishabh6788
Copy link
Contributor

@AMoo-Miki Can you please help us approving and merging this PR?

@VijayanB
Copy link
Member Author

Can i get review for this? Thanks

Copy link
Member

@nateynateynate nateynateynate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@nateynateynate nateynateynate merged commit a02c00e into opensearch-project:main May 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants