Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 2746: Remove breadcrumbs from all pages #2921

Merged

Conversation

kaimmej
Copy link
Contributor

@kaimmej kaimmej commented May 29, 2024

issue 2746 https://github.com/orgs/opensearch-project/projects/74/views/5?pane=issue&itemId=59588549

Description

references to Breadcrumbs have been removed from site. The breadcrumbs are still there in the frontmatter, I have just removed the rendering of them.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

Created new include file for page title and removed references to "page-breadcrumbs-and-title" from all pages.
Replaced with new page-title include file.

Signed-off-by: kaimmej <[email protected]>
@kaimmej
Copy link
Contributor Author

kaimmej commented May 29, 2024

Before
image

After
image

@nateynateynate
Copy link
Member

Issue: #2746

Copy link
Member

@nateynateynate nateynateynate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good locally. Let's get this out.

@nateynateynate nateynateynate merged commit 85306ed into opensearch-project:main Jul 12, 2024
4 of 5 checks passed
@kaimmej kaimmej deleted the removebreadcrumbs-2746 branch October 2, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants