-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt to core changes in SecureTransportParameters #5122
Adapt to core changes in SecureTransportParameters #5122
Conversation
Signed-off-by: Craig Perkins <[email protected]>
@finnegancarroll @rishabhmaurya @reta this fixes the compilation issues, but I'm not sure if it addresses what you need. How can we add testing for this? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5122 +/- ##
==========================================
+ Coverage 71.63% 71.67% +0.04%
==========================================
Files 335 335
Lines 22732 22747 +15
Branches 3598 3598
==========================================
+ Hits 16284 16304 +20
+ Misses 4649 4647 -2
+ Partials 1799 1796 -3
|
Thanks @cwperks , I think @rishabhmaurya has already confirmed it is what he needs :) |
@cwperks I think consumers of this interface should add tests for it. In security plugin, one test I can think of could be building |
Taking this out of Draft in case it needs to be merged to unblock the build. This PR needs test cases added to verify this change. |
Merging to unblock the build. I will follow this up w/ adding tests. |
Description
Adapts to changes introduced in opensearch-project/OpenSearch#16962
Testing
Not sure how to test this adequately.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.