Code

#3016 New expand PPL command#3305

Code

Draft

currantw wants to merge 81 commits intoopensearch-project:mainopensearch-project/sql:mainfrom Bit-Quill:#3016_expand_commandBit-Quill/opensearch-project-sql:#3016_expand_commandCopy head branch name to clipboard

+2,422-225

Commits

Commits on Feb 13, 2025

• Add flatten command to ANTLR lexer and parser.

  Show description for f462e2a
  currantw

  committed
  f462e2a

  Copy full SHA for f462e2a

• Skeleton implementation, tests, and documents with lots of TODOs.

  Show description for 69f0b1a
  currantw

  committed
  69f0b1a

  Copy full SHA for 69f0b1a

• Initial implementation

  Show description for c1ac737
  currantw

  committed
  c1ac737

  Copy full SHA for c1ac737

• Fix typo

  Show description for 366e162
  currantw

  committed
  366e162

  Copy full SHA for 366e162

• Initial implementation

  Show description for 0cbd8d4
  currantw

  committed
  0cbd8d4

  Copy full SHA for 0cbd8d4

• Update/fix tests.

  Show description for 26e9443
  currantw

  committed
  26e9443

  Copy full SHA for 26e9443

• Update integration tests to align with doc tests.

  Show description for 237b69e
  currantw

  committed
  237b69e

  Copy full SHA for 237b69e

• Minor cleanup.

  Show description for 3981c38
  currantw

  committed
  3981c38

  Copy full SHA for 3981c38

• Add ExplainIT tests for flatten

  Show description for 2ca7194
  currantw

  committed
  2ca7194

  Copy full SHA for 2ca7194

• Revert recursive flattening, add documentation, more test updates

  Show description for 9ddfc4a
  currantw

  committed
  9ddfc4a

  Copy full SHA for 9ddfc4a

• One more doctest fix

  Show description for c54c1f5
  currantw

  committed
  c54c1f5

  Copy full SHA for c54c1f5

• Fix ExplainIT error

  Show description for 8993e11
  currantw

  committed
  8993e11

  Copy full SHA for 8993e11

• Add additional test case to flatten.rst

  Show description for 288add2
  currantw

  committed
  288add2

  Copy full SHA for 288add2

• Fix FlattenCommandIT, add additional test case.

  Show description for eca3154
  currantw

  committed
  eca3154

  Copy full SHA for eca3154

• Fix PhysicalPlanNodeVisitor test coverage.

  Show description for c89a302
  currantw

  committed
  c89a302

  Copy full SHA for c89a302

• Review: use StringUtils.format instead of String.format.

  Show description for 9b2e9ce
  currantw

  committed
  9b2e9ce

  Copy full SHA for 9b2e9ce

• Fix LogicalFlattenTest.

  Show description for 82c8ccb
  currantw

  committed
  82c8ccb

  Copy full SHA for 82c8ccb

• Simplify algorithm for Analyzer.

  Show description for b7d8794
  currantw

  committed
  b7d8794

  Copy full SHA for b7d8794

• Update to support flattening nested structs.

  Show description for ca013ef
  currantw

  committed
  ca013ef

  Copy full SHA for ca013ef

• Fix unrelated bug in IPFUnctionsTest.

  Show description for 7920bd8
  currantw

  committed
  7920bd8

  Copy full SHA for 7920bd8

• Update IPFUnctionsTest to anchor at start.

  Show description for 9d6459f
  currantw

  committed
  9d6459f

  Copy full SHA for 9d6459f

• Minor cleanup.

  Show description for 6d040eb
  currantw

  committed
  6d040eb

  Copy full SHA for 6d040eb

• Fix doctest formatting.

  Show description for 43c0902
  currantw

  committed
  43c0902

  Copy full SHA for 43c0902

• Address minor review comments.

  Show description for 40362bf
  currantw

  committed
  40362bf

  Copy full SHA for 40362bf

• Fix doc tests.

  Show description for b0a6710
  currantw

  committed
  b0a6710

  Copy full SHA for b0a6710

• Update integratation tests to align with doc tests.

  Show description for be26660
  currantw

  committed
  be26660

  Copy full SHA for be26660

• Review - minor documentation updates.

  Show description for b3e4401
  currantw

  committed
  b3e4401

  Copy full SHA for b3e4401

• Remove double periods

  Show description for 4099f10
  currantw

  committed
  4099f10

  Copy full SHA for 4099f10

• Add comment on Map.equals.

  Show description for b96cefa
  currantw

  committed
  b96cefa

  Copy full SHA for b96cefa

• Remove unnecessary error checks.

  Show description for 72d98ed
  currantw

  committed
  72d98ed

  Copy full SHA for 72d98ed

• Update to maintain existing field.

  Show description for 4632c03
  currantw

  committed
  4632c03

  Copy full SHA for 4632c03

• Update for test coverage

  Show description for d755208
  currantw

  committed
  d755208

  Copy full SHA for d755208

• Simplify Analyzer implementation

  Show description for 09563ab
  currantw

  committed
  09563ab

  Copy full SHA for 09563ab

• Rename cities dataset to flatten

  Show description for 1d391ce
  currantw

  committed
  1d391ce

  Copy full SHA for 1d391ce

• SpotlessApply

  Show description for ef750f4
  currantw

  committed
  ef750f4

  Copy full SHA for ef750f4

• Minor doc cleanup.

  Show description for 14e005e
  currantw

  committed
  14e005e

  Copy full SHA for 14e005e

• Fix failing IT

  Show description for 73885a7
  currantw

  committed
  73885a7

  Copy full SHA for 73885a7

• Update incorrect documentation in Analyzer.visitFlatten.

  Show description for 4fbd320
  currantw

  committed
  4fbd320

  Copy full SHA for 4fbd320

• Update integ and doc tests to add another example of original field being preserved.

  Show description for 337fb01
  currantw

  committed
  337fb01

  Copy full SHA for 337fb01

• Review comment - move example to Analyzer.visitFlatten Javadoc.

  Show description for abe5c6c
  currantw

  committed
  abe5c6c

  Copy full SHA for abe5c6c

• Review comment - update Analyzer.visitFlatten Javadoc to specify that it also updates env, plus Javadoc formatting.

  Show description for a0022f4
  currantw

  committed
  a0022f4

  Copy full SHA for a0022f4

• Review comment - remove unnecessary @Getter

  Show description for df99d37
  currantw

  committed
  df99d37

  Copy full SHA for df99d37

• Review comments - add testStructNestedDeep test case

  Show description for 6883214
  currantw

  committed
  6883214

  Copy full SHA for 6883214

• Review comments - add testStructNestedDeep test case

  Show description for 94a4c8a
  currantw

  committed
  94a4c8a

  Copy full SHA for 94a4c8a

• Woops! Fix failing test.

  Show description for 26563c9
  currantw

  committed
  26563c9

  Copy full SHA for 26563c9

• Review comments - extract PathUtils constants

  Show description for bfb51a5
  currantw

  committed
  bfb51a5

  Copy full SHA for bfb51a5

• Review comments - update Analyzer to not use Optional.

  Show description for 22eccaf
  currantw

  committed
  22eccaf

  Copy full SHA for 22eccaf

• Bunch of additional review comments.

  Show description for dcd241a
  currantw

  committed
  dcd241a

  Copy full SHA for dcd241a

• Spotless

  Show description for befe55b
  currantw

  committed
  befe55b

  Copy full SHA for befe55b

• Spotless

  Show description for eb93cb1
  currantw

  committed
  eb93cb1

  Copy full SHA for eb93cb1

• Additional review comments, including move constants to ExprValueUtils.

  Show description for 1f05e85
  currantw

  committed
  1f05e85

  Copy full SHA for 1f05e85

• Review comments - update tests for exception msg

  Show description for db96c51
  currantw

  committed
  db96c51

  Copy full SHA for db96c51

• Review comments - simplify FlattenOperator.flattenExprValueAtPath.

  Show description for c1666ee
  currantw

  committed
  c1666ee

  Copy full SHA for c1666ee

• Change braces in documentation.

  Show description for 6e176a3
  currantw

  committed
  6e176a3

  Copy full SHA for 6e176a3

• Initial implementation of skeleton classes and methods.

  Show description for ab5a2fe
  currantw

  committed
  ab5a2fe

  Copy full SHA for ab5a2fe

• Implement some of the expand logic

  Show description for e7e5a5a
  currantw

  committed
  e7e5a5a

  Copy full SHA for e7e5a5a

• Add PathUtils and unit tests.

  Show description for a8f6855
  currantw

  committed
  a8f6855

  Copy full SHA for a8f6855

• Update ExpandOperator and unit tests.

  Show description for cf357ea
  currantw

  committed
  cf357ea

  Copy full SHA for cf357ea

• Implement integration tests, update Expand logic, rename data set.

  Show description for c260f6b
  currantw

  committed
  c260f6b

  Copy full SHA for c260f6b

• Implement integration tests, update Expand logic, rename data set.

  Show description for 0d3c33c
  currantw

  committed
  0d3c33c

  Copy full SHA for 0d3c33c

• Add expand.rst documentation and further updates to tests/implementation.

  Show description for 209326d
  currantw

  committed
  209326d

  Copy full SHA for 209326d

• Unrelated typo fix

  Show description for dd9a024
  currantw

  committed
  dd9a024

  Copy full SHA for dd9a024

• Cleanup, modify to return null for an empty array.

  Show description for e31df37
  currantw

  committed
  e31df37

  Copy full SHA for e31df37

• Fix test_docs.py typo, order alphabetically.

  Show description for 274719d
  currantw

  committed
  274719d

  Copy full SHA for 274719d

• Minor cleanup, mostly alphabetizing constants.

  Show description for 459ca24
  currantw

  committed
  459ca24

  Copy full SHA for 459ca24

• Add new doc and integration tests

  Show description for eef907f
  currantw

  committed
  eef907f

  Copy full SHA for eef907f

• Fix missing test coverage

  Show description for 77afac7
  currantw

  committed
  77afac7

  Copy full SHA for 77afac7

• Move PathUtils to ExprValueUtils and update tests.

  Show description for 49078e9
  currantw

  committed
  49078e9

  Copy full SHA for 49078e9

• Use ExprValueUtils to simplify FlattenOperator

  Show description for ff0d5ae
  currantw

  committed
  ff0d5ae

  Copy full SHA for ff0d5ae

• Simplify and make consistent flatten and expand operators.

  Show description for 790104c
  currantw

  committed
  790104c

  Copy full SHA for 790104c

• Update ExprValueUtils and unit tests.

  Show description for ec47f8f
  currantw

  committed
  ec47f8f

  Copy full SHA for ec47f8f

• Make constants private

  Show description for 101b653
  currantw

  committed
  101b653

  Copy full SHA for 101b653

• Spotless

  Show description for ec0f44f
  currantw

  committed
  ec0f44f

  Copy full SHA for ec0f44f

• Add hashCode unit tests

  Show description for da7738a
  currantw

  committed
  da7738a

  Copy full SHA for da7738a

• Trivial documentation cleanup.

  Show description for 4284f6f
  currantw

  committed
  4284f6f

  Copy full SHA for 4284f6f

• Fix doctest

  Show description for 1e51881
  currantw

  committed
  1e51881

  Copy full SHA for 1e51881

• General cleanup, combine flatten and expand datasets.

  Show description for c4f732e
  currantw

  committed
  c4f732e

  Copy full SHA for c4f732e

• Spotless

  Show description for 582fdaa
  currantw

  committed
  582fdaa

  Copy full SHA for 582fdaa

• Fix failing doctests

  Show description for e8494f2
  currantw

  committed
  e8494f2

  Copy full SHA for e8494f2

• Fix ExplainIT test

  Show description for 028e074
  currantw

  committed
  028e074

  Copy full SHA for 028e074

• Handle empty collections.

  Show description for 01569ae
  currantw

  committed
  01569ae

  Copy full SHA for 01569ae