Red Hat Konflux update osc-caa #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![red-hat-konflux[bot]](https://avatars.githubusercontent.com/in/296509?s=60&v=4){kind=small}
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
littlejawa
force-pushed
the
appstudio-osc-caa
branch
3 times, most recently
from
7d8062b to
3f8b192
Compare
|
There is no need to support iptables-wrapper. You can cherry-pick my commit here, or reproduce it yourself. |
littlejawa
force-pushed
the
appstudio-osc-caa
branch
from
0c5be74 to
1c56c07
Compare
|
Seems like we have something that builds ! |
|
@littlejawa your latest commit ace242e overwrites what you did with 3628d91. |
littlejawa
force-pushed
the
appstudio-osc-caa
branch
2 times, most recently
from
257e3ad to
dc31262
Compare
|
I'm removing iptables from the release image, to be consistent with what we are doing on the CPaaS builds. |
littlejawa
force-pushed
the
osc-release
branch
from
18c7f11 to
1f25c3e
Compare
Signed-off-by: red-hat-konflux <[email protected]>
We need to enable the CRB in the builder image, but this requires managing the subscription too. The activation key and org ID are already available to us through a mount file, so we should be able to use them. Making the same change in the release image, but commenting it out, as it seems the subscription is already done, and calling it again breaks the build. Keeping it as comments for local builds. Signed-off-by: Julien Ropé <[email protected]>
We don't need it on RHEL because we know the iptables mode we support, nft. The wrapper provides an easy way to support both "legacy" and "nft" modes when you don't know the system the container will run in. RHEL only supports nft, so there is no point in supporting legacy through the wrapper. See docs at https://github.com/kubernetes-sigs/iptables-wrappers
littlejawa
force-pushed
the
appstudio-osc-caa
branch
from
dc31262 to
6e96a37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content
/ok-to-testFor more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization