Skip to content

[WIP] CNTRLPLANE-5: Wire feature gates in oauth-apiserver #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[WIP] CNTRLPLANE-5: Wire feature gates in oauth-apiserver #767

wants to merge 2 commits into from
+66 −0

Conversation

bertinatto
Copy link
Member

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2025
@openshift-ci openshift-ci bot requested review from ibihim and liouk April 11, 2025 22:32
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bertinatto
Once this PR has been reviewed and has the lgtm label, please assign liouk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bertinatto bertinatto force-pushed the wire-feature-gates-oauth-apiserver branch 3 times, most recently from 53338c3 to ca55770 Compare April 14, 2025 19:39
@bertinatto bertinatto mentioned this pull request Apr 14, 2025
Open
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 14, 2025

@bertinatto: This PR was included in a payload test run from openshift/api#2235
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4c226b70-1969-11f0-9ef0-9286509f9fca-0

@bertinatto bertinatto force-pushed the wire-feature-gates-oauth-apiserver branch from ca55770 to 6b2811b Compare April 15, 2025 11:26
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 15, 2025

@bertinatto: This PR was included in a payload test run from openshift/api#2235
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a5e1a490-19ec-11f0-96f9-afbfd4019409-0

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 15, 2025

@bertinatto: This PR was included in a payload test run from openshift/api#2235
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e02bf9c0-19ec-11f0-8905-1b7d047e94ce-0

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 15, 2025

@bertinatto: This PR was included in a payload test run from openshift/api#2235
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/eb120b90-19ec-11f0-9991-21c38d7ac44d-0

@bertinatto bertinatto force-pushed the wire-feature-gates-oauth-apiserver branch from 6b2811b to 843aa1e Compare April 15, 2025 11:57
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 15, 2025

@bertinatto: This PR was included in a payload test run from openshift/api#2235
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e52be530-19f0-11f0-8997-2cc5eec7a803-0

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 15, 2025

@bertinatto: This PR was included in a payload test run from openshift/api#2235
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/415f6930-19f1-11f0-926b-14046135f88f-0

@bertinatto bertinatto force-pushed the wire-feature-gates-oauth-apiserver branch from 843aa1e to b00b6eb Compare April 15, 2025 12:28
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 15, 2025

@bertinatto: This PR was included in a payload test run from openshift/api#2235
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/21148440-19f5-11f0-8244-322e30889370-0

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 15, 2025

@bertinatto: This PR was included in a payload test run from openshift/api#2235
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/292778e0-19f5-11f0-9267-6bcf4a407b02-0

@bertinatto bertinatto changed the title WIP: Wire feature gates in oauth-apiserver [WIP] CNTRLPLANE05: Wire feature gates in oauth-apiserver Apr 15, 2025
@bertinatto bertinatto force-pushed the wire-feature-gates-oauth-apiserver branch from b00b6eb to f3a0250 Compare April 15, 2025 18:33
@bertinatto bertinatto changed the title [WIP] CNTRLPLANE05: Wire feature gates in oauth-apiserver [WIP] CNTRLPLANE-05: Wire feature gates in oauth-apiserver Apr 15, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 15, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 15, 2025 •
edited by openshift-ci bot
Loading

@bertinatto: This pull request references CNTRLPLANE-05 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bertinatto bertinatto changed the title [WIP] CNTRLPLANE-05: Wire feature gates in oauth-apiserver [WIP] CNTRLPLANE-5: Wire feature gates in oauth-apiserver Apr 15, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 15, 2025 •
edited by openshift-ci bot
Loading

@bertinatto: This pull request references CNTRLPLANE-5 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 23, 2025

@bertinatto: This PR was included in a payload test run from openshift/api#2235
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/43909df0-207c-11f0-8659-937a87466078-0

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 23, 2025

@bertinatto: This PR was included in a payload test run from openshift/api#2235
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/74381840-2093-11f0-9b65-538610ba2797-0

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 24, 2025

@bertinatto: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 833c98b link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-operator 833c98b link true /test e2e-operator
ci/prow/e2e-agnostic-ipv6 833c98b link false /test e2e-agnostic-ipv6
ci/prow/test-operator-integration 833c98b link false /test test-operator-integration

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 24, 2025

@bertinatto: This PR was included in a payload test run from openshift/api#2235
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c2a8b8f0-2146-11f0-8db2-e5ab18654ff2-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibihim ibihim Awaiting requested review from ibihim

@liouk liouk Awaiting requested review from liouk

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bertinatto @openshift-ci-robot