-
Notifications
You must be signed in to change notification settings - Fork 49
OSD - 29470: To create E2E Tests for CAD - Cluster has gone missing - Infra Nodes turned off #441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ratnam915
wants to merge
12
commits into
openshift:main
Choose a base branch
from
ratnam915:feature/OSD-29470
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a4d54d8
Final changes
ratnam915 33193e0
Merge branch 'openshift:main' into feature/OSD-29470
ratnam915 d3983f7
Final changes
ratnam915 b56b542
Made changes as per the comments recieved
ratnam915 d73f99a
Merge branch 'openshift:main' into feature/OSD-29470
ratnam915 4ea9c58
Made changes as per the commits
ratnam915 2bee8ab
Merge branch 'openshift:main' into feature/OSD-29470
ratnam915 2e886c2
Final changes
ratnam915 5451228
Changed the PagerDuty token
ratnam915 60759ed
Fixed lint issue
ratnam915 8df9a97
Fixed lint issue
ratnam915 c250a8e
Fixed lint issue
ratnam915 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is the failure case, I'd love for this to actual
Fail
but stil cleanup.Maybe starting all stopped Infras could be a
AfterEach
function in the context?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bergmannf : The above code has been fixed to restart the nodes irrespective the test status, also the test case was run post the change and it was a success