-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-44995: Update the storage.conf configuration file template #4681
OCPBUGS-44995: Update the storage.conf configuration file template #4681
Conversation
Signed-off-by: Krzysztof Wilczyński <[email protected]>
/assign kwilczynski |
@haircommander, please have a look when you have a moment. Thank you! |
/approve |
/retest |
3 similar comments
/retest |
/retest |
/retest |
96ad5f1
to
18a0dc6
Compare
/retest |
6 similar comments
/retest |
/retest |
/retest |
/retest |
/retest |
/retest |
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, kwilczynski, LorbusChris The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label acknowledge-critical-fixes-only |
@kwilczynski: This pull request references Jira Issue OCPBUGS-44995, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@kwilczynski: This pull request references Jira Issue OCPBUGS-44995, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@kwilczynski: This pull request references Jira Issue OCPBUGS-44995, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@kwilczynski: This pull request references Jira Issue OCPBUGS-44995, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
228824d
into
openshift:master
@kwilczynski: Jira Issue OCPBUGS-44995: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-44995 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/cherry-pick release-4.17 |
@kwilczynski: new pull request created: #4719 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherry-pick release-4.16 |
@kwilczynski: new pull request created: #4720 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherry-pick release-4.15 |
@kwilczynski: new pull request created: #4721 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherry-pick release-4.14 |
@kwilczynski: new pull request created: #4722 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherry-pick release-4.18 |
@kwilczynski: new pull request created: #4751 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
- What I did
Updated current storage.conf configuration file template to reflect changes made over time to the upstream dependencies such as containers/storage package, etc. The changes include:
size
attribute from thestorage
table into the specific file system driver tablerunroot
property from thestorage
table to reflect changes to the temporary directory default locationstorage.options
tableRemap-User/Group
settings precedence overRemap-UIDs/GIDs
when both are setstorage.options.thinpool
table entirely, as the support for DeviceMapper driver has been removeduse_hard_links
andostree_repos
properties tostorage.options.pull_options
table with their default valuesRelated:
- How to verify it
Run a test OpenShift cluster using ClusterBot that references this Pull Request, or manually apply configuration file changes against a running CRI-O instance and reload the configuration file or restart the service itself.
- Description for the changelog
Update the storage.conf configuration file template to reflect changes made over time to the upstream dependencies.