Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-44995: Update the storage.conf configuration file template #4681

Conversation

kwilczynski
Copy link
Contributor

@kwilczynski kwilczynski commented Nov 5, 2024

- What I did

Updated current storage.conf configuration file template to reflect changes made over time to the upstream dependencies such as containers/storage package, etc. The changes include:

  • Move the size attribute from the storage table into the specific file system driver table
  • Update the runroot property from the storage table to reflect changes to the temporary directory default location
  • Mention the storage.options table Remap-User/Group settings precedence over Remap-UIDs/GIDs when both are set
  • Remove the storage.options.thinpool table entirely, as the support for DeviceMapper driver has been removed
  • Disable the partial container image downloads as it is still considered an experimental feature that should be opt-in
  • Add use_hard_links and ostree_repos properties to storage.options.pull_options table with their default values

Related:

- How to verify it

Run a test OpenShift cluster using ClusterBot that references this Pull Request, or manually apply configuration file changes against a running CRI-O instance and reload the configuration file or restart the service itself.

- Description for the changelog

Update the storage.conf configuration file template to reflect changes made over time to the upstream dependencies.

@kwilczynski
Copy link
Contributor Author

/assign kwilczynski

@kwilczynski
Copy link
Contributor Author

@giuseppe and @mtrmac, please have a look. Thank you!

@kwilczynski
Copy link
Contributor Author

@haircommander, please have a look when you have a moment. Thank you!

@haircommander
Copy link
Member

/approve

@kwilczynski
Copy link
Contributor Author

/retest

3 similar comments
@kwilczynski
Copy link
Contributor Author

/retest

@kwilczynski
Copy link
Contributor Author

/retest

@kwilczynski
Copy link
Contributor Author

/retest

@kwilczynski kwilczynski force-pushed the feature/update-storage.conf-for-cri-o branch from 96ad5f1 to 18a0dc6 Compare November 7, 2024 10:30
@kwilczynski
Copy link
Contributor Author

/retest

6 similar comments
@kwilczynski
Copy link
Contributor Author

/retest

@kwilczynski
Copy link
Contributor Author

/retest

@kwilczynski
Copy link
Contributor Author

/retest

@kwilczynski
Copy link
Contributor Author

/retest

@kwilczynski
Copy link
Contributor Author

/retest

@kwilczynski
Copy link
Contributor Author

/retest

@LorbusChris
Copy link
Member

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2024
@LorbusChris
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2024
Copy link
Contributor

openshift-ci bot commented Nov 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, kwilczynski, LorbusChris

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LorbusChris
Copy link
Member

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Nov 25, 2024
@kwilczynski kwilczynski changed the title Update the storage.conf configuration file template OCPBUGS-44995: Update the storage.conf configuration file template Nov 25, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 25, 2024
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 25, 2024
@openshift-ci-robot
Copy link
Contributor

@kwilczynski: This pull request references Jira Issue OCPBUGS-44995, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

- What I did

Updated current storage.conf configuration file template to reflect changes made over time to the upstream dependencies such as containers/storage package, etc. The changes include:

  • Move the size attribute from the storage table into the specific file system driver table
  • Update the runroot property from the storage table to reflect changes to the temporary directory default location
  • Mention the storage.options table Remap-User/Group settings precedence over Remap-UIDs/GIDs when both are set
  • Remove the storage.options.thinpool table entirely, as the support for DeviceMapper driver has been removed
  • Disable the partial container image downloads as it is still considered an experimental feature that should be opt-in
  • Add use_hard_links and ostree_repos properties to storage.options.pull_options table with their default values

Related:

- How to verify it

Run a test OpenShift cluster using ClusterBot that references this Pull Request, or manually apply configuration file changes against a running CRI-O instance and reload the configuration file or restart the service itself.

- Description for the changelog

Update the storage.conf configuration file template to reflect changes made over time to the upstream dependencies.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kwilczynski
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@kwilczynski: This pull request references Jira Issue OCPBUGS-44995, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kwilczynski
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@kwilczynski: This pull request references Jira Issue OCPBUGS-44995, which is invalid:

  • expected the bug to target only the "4.19.0" version, but multiple target versions were set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kwilczynski
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 25, 2024
@openshift-ci-robot
Copy link
Contributor

@kwilczynski: This pull request references Jira Issue OCPBUGS-44995, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from sergiordlr November 25, 2024 20:31
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 7ba69ba and 2 for PR HEAD 18a0dc6 in total

@openshift-merge-bot openshift-merge-bot bot merged commit 228824d into openshift:master Nov 26, 2024
17 of 18 checks passed
@openshift-ci-robot
Copy link
Contributor

@kwilczynski: Jira Issue OCPBUGS-44995: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-44995 has been moved to the MODIFIED state.

In response to this:

- What I did

Updated current storage.conf configuration file template to reflect changes made over time to the upstream dependencies such as containers/storage package, etc. The changes include:

  • Move the size attribute from the storage table into the specific file system driver table
  • Update the runroot property from the storage table to reflect changes to the temporary directory default location
  • Mention the storage.options table Remap-User/Group settings precedence over Remap-UIDs/GIDs when both are set
  • Remove the storage.options.thinpool table entirely, as the support for DeviceMapper driver has been removed
  • Disable the partial container image downloads as it is still considered an experimental feature that should be opt-in
  • Add use_hard_links and ostree_repos properties to storage.options.pull_options table with their default values

Related:

- How to verify it

Run a test OpenShift cluster using ClusterBot that references this Pull Request, or manually apply configuration file changes against a running CRI-O instance and reload the configuration file or restart the service itself.

- Description for the changelog

Update the storage.conf configuration file template to reflect changes made over time to the upstream dependencies.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kwilczynski kwilczynski deleted the feature/update-storage.conf-for-cri-o branch November 26, 2024 11:41
@kwilczynski
Copy link
Contributor Author

/cherry-pick release-4.17

@openshift-cherrypick-robot

@kwilczynski: new pull request created: #4719

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kwilczynski
Copy link
Contributor Author

/cherry-pick release-4.16

@openshift-cherrypick-robot

@kwilczynski: new pull request created: #4720

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kwilczynski
Copy link
Contributor Author

/cherry-pick release-4.15

@openshift-cherrypick-robot

@kwilczynski: new pull request created: #4721

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kwilczynski
Copy link
Contributor Author

/cherry-pick release-4.14

@openshift-cherrypick-robot

@kwilczynski: new pull request created: #4722

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kwilczynski
Copy link
Contributor Author

/cherry-pick release-4.18

@openshift-cherrypick-robot

@kwilczynski: new pull request created: #4751

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants