Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2no-ha extension support required by Two Node OpenShift #4843

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fabbione
Copy link

See: https://issues.redhat.com/browse/OCPEDGE-1493

- Description for the changelog

Add 2no-ha extension support required by Two Node OpenShift

Copy link
Contributor

openshift-ci bot commented Feb 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fabbione
Once this PR has been reviewed and has the lgtm label, please assign yuqi-zhang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 11, 2025
Copy link
Contributor

openshift-ci bot commented Feb 11, 2025

Hi @fabbione. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@fabbione
Copy link
Author

fabbione commented Feb 11, 2025

Hey guys,

very first time contributing to RHCOS, I am sure I missed a few bits here and there, hopefully not too many :)

the name 2no-ha was explicity selected to avoid using HighAvailability as in the context of OpenShift could
be misleading. The RHEL HighAvailability channel provides the packages required for Two Nodes OpenShift
controller plane deployments.

See also:
https://gitlab.cee.redhat.com/coreos/redhat-coreos/-/merge_requests/1553
openshift/os#1743
#4843
openshift-eng/ocp-build-data#6091
openshift/release#61519

@fabbione
Copy link
Author

As noted in openshift/os#1743 (review) I will rename 2no-ha to two-node-ha. I will update this PR as well tomorrow.

@fabbione
Copy link
Author

Rename from 2no-ha to two-node-ha is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant