-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move required build files to configmap for clarity #4847
base: master
Are you sure you want to change the base?
move required build files to configmap for clarity #4847
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheesesashimi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0630835
to
8976475
Compare
Having looked at the changes to the buildah-build.sh script and the inner-script, they both correctly utilize users. |
I had a question of how |
8976475
to
769d0cb
Compare
Those are the resolved packaegs that we get from the various extensions that someone wishes to install. Previously, we were just passing them to |
- What I did
The Containerfile template has a lot of indirection contained within it which
is very difficult to reason about and debug, especially when templating is
involved. To make this easier, I extracted as much as possible from the various
build scripts and pushed those scripts into the Containerfile ConfigMap via the
buildrequest/assets
directory.- How to verify it
Everything should continue to work as-is. This should be tested against a proxy-enabled cluster just to validate that these changes did not have any unintended side-effects.
- Description for the changelog
Move required build files to ConfigMap for clarity