Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interop - Decrease oc version for ODO on OCP 4.16 #52410

Closed
wants to merge 1 commit into from

Conversation

oharan2
Copy link
Contributor

@oharan2 oharan2 commented May 23, 2024

No description provided.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@oharan2: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-redhat-developer-odo-main-odo-ocp4.16-lp-interop-images redhat-developer/odo presubmit Ci-operator config changed
periodic-ci-redhat-developer-odo-main-odo-ocp4.16-lp-interop-odo-scenario-aws N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@oharan2
Copy link
Contributor Author

oharan2 commented May 23, 2024

/pj-rehearse pull-ci-redhat-developer-odo-main-odo-ocp4.16-lp-interop-images

@openshift-ci-robot
Copy link
Contributor

@oharan2: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@oharan2
Copy link
Contributor Author

oharan2 commented May 23, 2024

/pj-rehearse periodic-ci-redhat-developer-odo-main-odo-ocp4.16-lp-interop-odo-scenario-aws

@openshift-ci-robot
Copy link
Contributor

@oharan2: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot requested review from feloy and kadel May 23, 2024 08:54
Copy link
Contributor

openshift-ci bot commented May 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oharan2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2024
@oharan2
Copy link
Contributor Author

oharan2 commented May 23, 2024

/pj-rehearse periodic-ci-redhat-developer-odo-main-odo-ocp4.16-lp-interop-odo-scenario-aws

@openshift-ci-robot
Copy link
Contributor

@oharan2: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@@ -1,6 +1,6 @@
base_images:
cli:
name: "4.16"
name: "4.15"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is no longer necessary for odo. I had pushed some changes in the build_root image for odo to use RHEL 9 as the base image - see redhat-developer/odo#7243

Now, the latest run of the interop tests is fine. Well, they are still failing but due to some flaky odo tests instead, not because of missing GLIBC libraries. See https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-redhat-developer-odo-main-odo-ocp4.16-lp-interop-odo-scenario-aws/1793348683945742336

So to me, this PR is not needed for odo. WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, closing this PR. thanks

@oharan2 oharan2 closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants