-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPQE-28542: Support deploy Quay with unmanaged GCP PostgreSQL Database with Client Key/Certs #61753
Conversation
/pj-rehearse periodic-ci-quay-quay-tests-master-ocp-418-quay-quay-e2e-tests-quay313-gcp-sql |
@SeanZhao-redhat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse periodic-ci-quay-quay-tests-master-quay-operator-test-quay313-ocp417-operator-test-singlens |
@SeanZhao-redhat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse periodic-ci-quay-quay-tests-master-ocp-417-quay-quay-e2e-tests-quay313-ocp417-aws-sts |
@SeanZhao-redhat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse periodic-ci-quay-quay-tests-master-ocp-417-quay-quay-e2e-tests-quay313-ocp417-virtual-builder |
@SeanZhao-redhat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse periodic-ci-quay-quay-tests-master-ocp-417-quay-quay-acs-violations-check-quay313 |
@SeanZhao-redhat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse ack |
@SeanZhao-redhat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
@SeanZhao-redhat: This pull request references OCPQE-28542 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
/pj-rehearse ack |
@SeanZhao-redhat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse periodic-ci-quay-quay-tests-master-ocp-418-quay-quay-e2e-tests-quay313-gcp-sql |
@SeanZhao-redhat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LiZhang19817, SeanZhao-redhat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…se with Client Key/Certs (openshift#61753) * provisioning rosa env for quay * Update rosa-sts-oidc-config-delete-ref.yaml * Update rosa-sts-oidc-config-delete-commands.sh * fix conflict * initialize step enable-quay-catalogsource * rollback * remove useless file * init google cloud sql * checkin cmd * fix missing variable * fix extension * add registry * add registry * fix secret bundle * update tf file * update deprovision * update destory script * update destroy * update instance with RANDOM * change back deprovision seq * change back deprovision seq * delete res before destroy instance * update tf files * update comments * update copycert * update cron
This PR add support for Google Cloud SQL Postgres instance support, including a step to provision/deprovision GCP Cloud SQL and Quay registry deploy with the Unmanaged GCP SQL with Client Key/Certs.
1, New steps added
1, Provision Google Cloud SQL Postgres instance
Usage :
Database instance "SSL mode" is Managed as: Require trusted client certificates
Output: $SHARED_DIR folder client-cert.pem, client-key.pem, server-ca.pem, gsql_db_public_ip,QUAY_GCP_SQL_TERRAFORM_PACKAGE.tgz for secret bundle and deprovision
2, Deploy Quay registry with Google Cloud SQL PostgreSQL with Client certs
Usage:
All the 2 env variables can keep default value, the secret bundle must be named postgresql-client-certs which include previous generated client-cert.pem, client-key.pem, server-ca.pem
3, Deprovision GCP SQL Postgres instance
Usage :
NOTE: Deprovision GCP SQL Database with Terraform has Known intermittent issue Failed to delete user, Error delete database. the tricky is, this seldom happen in my local terraform test, but very easy happen in Prow, error log1, error log2. The workaround to remove google_sql_user.users/google_sql_database.database state from terraform before destroy, this works passed log.
2, Job reference to several single responsibility steps
Job:
quay-e2e-tests-quay313-gcp-sql
3, Job result
Quay api test passed, Provision/Deprovision GSQL Successful Test Result
4, Miscellaneous
A few polish for previous jobs