Adding rds-core to e2e-ci #62177
Adding rds-core to e2e-ci #62177
Conversation
Signed-off-by: Vishnu Challa <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vishnuchalla The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/pj-rehearse pull-ci-cloud-bulldozer-e2e-benchmarking-master-e2e-rds-core-single-node |
|
@vishnuchalla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/assign @josecastillolema |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
@vishnuchalla: job(s): pull-ci-cloud-bulldozer-e2e-benchmarking-master-e2e-rds-core-single-node either don't exist or were not found to be affected, and cannot be rehearsed |
| pushd /tmp | ||
|
|
||
|
|
||
| git clone https://github.com/vishnuchalla/e2e-benchmarking --branch v0.0.1 --depth 1 |
There was a problem hiding this comment.
This is to quickly test this functionality. Once done we will add checks to only run on e2e PRs.
There was a problem hiding this comment.
Could we have this step moved to ci-operator/step-registry/openshift-qe/rds-core instead please?
Also, you may want to assign yourself to PERFSCALE-3646 - Create a RDS Prow step
There was a problem hiding this comment.
Thanks for sharing the JIRA. I have hyperlinked in the one I have in this PR description.
There was a problem hiding this comment.
Could we have this step moved to ci-operator/step-registry/openshift-qe/rds-core instead please?
Unfortunately no. This test has a different purpose to only run against e2e CI. And we want these e2e CI tests to be decoupled from the actual production CI runs to avoid unnecessary noise.
For example if we look at cd-v2, we have two versions of it.
One is the actual production run: https://github.com/openshift/release/tree/master/ci-operator/step-registry/openshift-qe/cluster-density-v2
Another that runs againt e2e CI with minimal configuration: https://github.com/openshift/release/tree/master/ci-operator/step-registry/cloud-bulldozer/e2e-benchmarking/cluster-density-v2
Both are different and have a different purpose.
There was a problem hiding this comment.
Ahh ok I wasnt aware that there where two of them, noted.
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/pj-rehearse pull-ci-cloud-bulldozer-e2e-benchmarking-master-e2e-rds-core-single-node |
|
@vishnuchalla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@vishnuchalla: job(s): pull-ci-cloud-bulldozer-e2e-benchmarking-master-e2e-rds-core-single-node either don't exist or were not found to be affected, and cannot be rehearsed |
| - intranet | ||
| restrict_network_access: false | ||
| steps: | ||
| cluster_profile: metal-perscale-cpt |
There was a problem hiding this comment.
I dont think this is the right place to test this. A better candidate would be the jetlag ci cluster:
cluster_profile: metal-perfscale-jetlag
Also to move to the jetlag CI cluster you need to add some envs:
BASTION_CP_INTERFACE: ens7f1
LAB_CLOUD: cloud19
LAB_INTERFACE: eno3
NUM_WORKER_NODES: "2"
There was a problem hiding this comment.
Also, may need to overwrite some vars to adjust the SRIOV and the perf-profile setup to the jetlag CI cluster
There was a problem hiding this comment.
@josecastillolema may I know why are you suggesting jetlag CI over this one? If this is aiming movement of all our current jobs, can we take it in a different PR?
There was a problem hiding this comment.
Not all the current jobs, but the e2e-bencharking CI will be better placed on the jetlag CI environment for several reasons:
- The BM CPT env is almost fully occupied all the day, we have 2 daily tests (each of them taking about 6/7h) + some weekly tests.
- @jtaleric and I have been discussing how we would like to leave the BM CPT cluster for "production" data and leverage the jetlag CI cluster for the functional testing moving forward.
There was a problem hiding this comment.
Understood and acknowledged.
vishnuchalla
force-pushed
the
rds-core
branch
from
413179b to
8255107
Compare
|
/pj-rehearse network-access-allowed |
|
@vishnuchalla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@vishnuchalla: PR author isn't allowed to allow network access rehearsals. This must be done by a different member of the |
vishnuchalla
force-pushed
the
rds-core
branch
from
8255107 to
a56a238
Compare
vishnuchalla
force-pushed
the
rds-core
branch
from
a56a238 to
a4b15d2
Compare
|
/pj-rehearse network-access-allowed |
|
@mohit-sheth: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-cloud-bulldozer-e2e-benchmarking-master-e2e-rds-core-single-node |
|
@vishnuchalla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
| oc config view | ||
| oc projects | ||
| pushd /tmp | ||
|
|
There was a problem hiding this comment.
You are missing some pre-reqs: https://github.com/kube-burner/kube-burner-ocp/tree/main?tab=readme-ov-file#core-rds-workloads
We need one host labeled as worker-dpdk and another one as worker-metallb. In openshift-qe/installer/bm/day2/label there is a step that you can reuse to label the nodes.
vishnuchalla
force-pushed
the
rds-core
branch
from
a4b15d2 to
adc042b
Compare
|
/pj-rehearse network-access-allowed |
|
@mohit-sheth: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-cloud-bulldozer-e2e-benchmarking-master-e2e-rds-core-single-node |
|
@vishnuchalla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
vishnuchalla
force-pushed
the
rds-core
branch
from
adc042b to
73bbe60
Compare
|
/pj-rehearse pull-ci-cloud-bulldozer-e2e-benchmarking-master-e2e-rds-core-single-node |
|
@vishnuchalla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@vishnuchalla: job(s): pull-ci-cloud-bulldozer-e2e-benchmarking-master-e2e-rds-core-single-node either don't exist or were not found to be affected, and cannot be rehearsed |
|
/pj-rehearse network-access-allowed |
|
@jubittajohn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-cloud-bulldozer-e2e-benchmarking-master-e2e-rds-core-single-node |
|
@vishnuchalla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Signed-off-by: Vishnu Challa <[email protected]>
vishnuchalla
force-pushed
the
rds-core
branch
from
73bbe60 to
2164e37
Compare
Signed-off-by: Vishnu Challa <[email protected]>
|
[REHEARSALNOTIFIER]
The following jobs are not rehearsable without the
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@vishnuchalla: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Adding rds-core to e2e-ci
JIRA: https://issues.redhat.com/browse/PERFSCALE-3705
Testing
Need to verify it through this PR rehearsal