Skip to content

hive: pass basedomain for azure clusters#76389

Open
patrickdillon wants to merge 1 commit intoopenshift:mainfrom
patrickdillon:hive-dns-cluster-profile
Open

hive: pass basedomain for azure clusters#76389
patrickdillon wants to merge 1 commit intoopenshift:mainfrom
patrickdillon:hive-dns-cluster-profile

Conversation

@patrickdillon
Copy link
Contributor

@patrickdillon patrickdillon commented Mar 17, 2026

follow up to: #76068

That PR updates Azure jobs so that they may land in different Azure subscriptions and therefore base domain. For hive, we also need to pass that base domain information to be used by the spoke cluster.

This is the same approach as vsphere, which must be balancing as well

follow up to: openshift#76068

That PR updates Azure jobs so that they may land in different
Azure subscriptions and therefore base domain. For hive, we also
need to pass that base domain information to be used by the spoke
cluster.
@openshift-ci openshift-ci bot requested review from dgoodwin and jstuever March 17, 2026 10:23
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: patrickdillon
Once this PR has been reviewed and has the lgtm label, please assign 2uasimojo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@patrickdillon: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-baremetal-operator-main-e2e-agnostic-ovn openshift/cluster-baremetal-operator presubmit Registry content changed
pull-ci-openshift-cluster-baremetal-operator-release-5.0-e2e-agnostic-ovn openshift/cluster-baremetal-operator presubmit Registry content changed
pull-ci-openshift-cluster-baremetal-operator-release-4.23-e2e-agnostic-ovn openshift/cluster-baremetal-operator presubmit Registry content changed
pull-ci-openshift-cluster-baremetal-operator-release-4.22-e2e-agnostic-ovn openshift/cluster-baremetal-operator presubmit Registry content changed
pull-ci-openshift-cluster-baremetal-operator-release-4.21-e2e-agnostic-ovn openshift/cluster-baremetal-operator presubmit Registry content changed
pull-ci-openshift-cluster-baremetal-operator-release-4.20-e2e-agnostic-ovn openshift/cluster-baremetal-operator presubmit Registry content changed
pull-ci-openshift-cluster-baremetal-operator-release-4.19-e2e-agnostic-ovn openshift/cluster-baremetal-operator presubmit Registry content changed
pull-ci-openshift-cluster-baremetal-operator-release-4.18-e2e-agnostic-ovn openshift/cluster-baremetal-operator presubmit Registry content changed
pull-ci-openshift-cluster-baremetal-operator-release-4.17-e2e-agnostic-ovn openshift/cluster-baremetal-operator presubmit Registry content changed
pull-ci-openshift-cluster-baremetal-operator-release-4.16-e2e-agnostic-ovn openshift/cluster-baremetal-operator presubmit Registry content changed
pull-ci-openshift-cluster-baremetal-operator-release-4.15-e2e-agnostic-ovn openshift/cluster-baremetal-operator presubmit Registry content changed
pull-ci-openshift-cluster-baremetal-operator-release-4.14-e2e-agnostic-ovn openshift/cluster-baremetal-operator presubmit Registry content changed
pull-ci-openshift-cluster-baremetal-operator-release-4.13-e2e-agnostic-ovn openshift/cluster-baremetal-operator presubmit Registry content changed
pull-ci-openshift-cluster-baremetal-operator-release-4.12-e2e-agnostic-ovn openshift/cluster-baremetal-operator presubmit Registry content changed
pull-ci-openshift-cluster-baremetal-operator-release-4.11-e2e-agnostic openshift/cluster-baremetal-operator presubmit Registry content changed
pull-ci-openshift-cluster-baremetal-operator-release-4.10-e2e-agnostic openshift/cluster-baremetal-operator presubmit Registry content changed
pull-ci-openshift-cluster-baremetal-operator-release-4.9-e2e-agnostic openshift/cluster-baremetal-operator presubmit Registry content changed
pull-ci-openshift-cluster-baremetal-operator-release-4.8-e2e-agnostic openshift/cluster-baremetal-operator presubmit Registry content changed
pull-ci-openshift-cluster-baremetal-operator-release-4.7-e2e-agnostic openshift/cluster-baremetal-operator presubmit Registry content changed
pull-ci-openshift-csi-operator-main-e2e-azure openshift/csi-operator presubmit Registry content changed
pull-ci-openshift-csi-operator-release-5.0-e2e-azure openshift/csi-operator presubmit Registry content changed
pull-ci-openshift-csi-operator-release-4.23-e2e-azure openshift/csi-operator presubmit Registry content changed
pull-ci-openshift-csi-operator-release-4.22-e2e-azure openshift/csi-operator presubmit Registry content changed
pull-ci-openshift-csi-operator-release-4.21-e2e-azure openshift/csi-operator presubmit Registry content changed
pull-ci-openshift-csi-operator-release-4.20-e2e-azure openshift/csi-operator presubmit Registry content changed

A total of 4988 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2026

@patrickdillon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@patrickdillon
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-hive-master-e2e-azure
/pj-rehearse periodic-ci-openshift-hive-master-periodic-e2e-azure-weekly

@openshift-ci-robot
Copy link
Contributor

@patrickdillon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@patrickdillon: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants